Closed Bug 799196 Opened 8 years ago Closed 8 years ago

warning: ‘virtual nsresult nsFrame::List(FILE*, int32_t, uint32_t) const’ was hidden ...by ‘virtual nsresult nsHTMLFramesetBlankFrame::List(FILE*, int32_t) const’

Categories

(Core :: Layout, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

Just noticed this build warning go by:

/mozilla/layout/generic/nsFrame.h:661:60: warning: ‘virtual nsresult nsFrame::List(FILE*, int32_t, uint32_t) const’ was hidden [-Woverloaded-virtual]
/mozilla/layout/generic/nsFrameSetFrame.cpp:   by ‘virtual nsresult nsHTMLFramesetBlankFrame::List(FILE*, int32_t) const’
/mozilla/layout/generic/nsFrameSetFrame.cpp:143:60: warning:   by ‘virtual nsresult nsHTMLFramesetBlankFrame::List(FILE*, int32_t) const’ [-Woverloaded-virtual]

Looks like Bug 788202 (which changed the "List()" signature) didn't update the nsFrameSetFrame impl.
Or rather, the "nsHTMLFramesetBlankFrame" impl.
Attached patch fixSplinter Review
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #669221 - Flags: review?(bzbarsky)
Comment on attachment 669221 [details] [diff] [review]
fix

r=me
Attachment #669221 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/b815cdf08cad
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in before you can comment on or make changes to this bug.