Closed
Bug 799196
Opened 13 years ago
Closed 13 years ago
warning: ‘virtual nsresult nsFrame::List(FILE*, int32_t, uint32_t) const’ was hidden ...by ‘virtual nsresult nsHTMLFramesetBlankFrame::List(FILE*, int32_t) const’
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
|
2.11 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Just noticed this build warning go by:
/mozilla/layout/generic/nsFrame.h:661:60: warning: ‘virtual nsresult nsFrame::List(FILE*, int32_t, uint32_t) const’ was hidden [-Woverloaded-virtual]
/mozilla/layout/generic/nsFrameSetFrame.cpp: by ‘virtual nsresult nsHTMLFramesetBlankFrame::List(FILE*, int32_t) const’
/mozilla/layout/generic/nsFrameSetFrame.cpp:143:60: warning: by ‘virtual nsresult nsHTMLFramesetBlankFrame::List(FILE*, int32_t) const’ [-Woverloaded-virtual]
Looks like Bug 788202 (which changed the "List()" signature) didn't update the nsFrameSetFrame impl.
|
Assignee | |
Comment 1•13 years ago
|
||
Or rather, the "nsHTMLFramesetBlankFrame" impl.
|
|
Assignee | |
Comment 2•13 years ago
|
||
|
||
Comment 3•13 years ago
|
||
Comment on attachment 669221 [details] [diff] [review]
fix
r=me
Attachment #669221 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
|
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
You need to log in
before you can comment on or make changes to this bug.
Description
•