788302 - Make version check tests independent

Status: RESOLVED INVALID

(addons.mozilla.org Graveyard :: API, defect)

Description

[Andy McKay]

Version check tests currently require:

- a database setup in a particular way
- a bunch of fixtures loaded in using those fixtures

Those require there to be Django, amo models and so on. I don't have a problem with tests using Django, it provides lots of useful features. But to get the model definitions, you've pretty much got to import all of zamboni. Ugh.

Ideally I'd like to have all the model definitions separate from all the rest, but up for any smart ideas on this.

Comment 1

[Alexis Metaireau (:alexis)]

Okay, so it seems that the plan is to put the model definitions in gelato.models and to use these in the version-check code.

It seems to me that we could have something like this:

1. Zamboni exposes an API which enables anyone to get information about specific apps
2. Zamboni exposes an HTTP stream which allows any third party to get updates in almost real-time about the latest apps that changed

This means that we could test this API directly. If we want to test the whole regeneration flow, I think we should have an API (behind a VPN) with some specific URIs allowing to put the db in a particular state and to reset it to this state just after.

That's a kind of "rollback the state of our db to a known state after running the tests". This way, we can functionaly test that the version-check client is behaving the good way.

Please note that this doesn't replace the unit tests about the streaming if we decide to add this to zamboni / market place.

I'm up to work on this :-)

Comment 2

[Andy McKay]

I think this ship has sailed.