788381 - Resubmit isn't a valid option for packaged app

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P3)

Description

[Rob Hudson [:robhudson]]

For hosted apps that are rejected we allow the developer to resubmit (with a comment) since they are able to fix the issues on their server.

For packaged apps this won't work -- a "resubmit" would require a new file upload. For this path flow we need to either allow an upload & replace version, or delete version + upload again. In the end they are the same but not sure which wording is better or what the flow would look like exactly. There may be something in add-ons that handles this well already.

Filing to clean this up.

Comment 1

[Rob Hudson [:robhudson]]

Attachment: Resubmit flow for hosted apps

Comment 2

[Rob Hudson [:robhudson]]

It was suggested by Krupa that if the developer uploads a packaged app with the same version string, we could offer to replace the current version with this one (or cancel). But only if the existing version hasn't yet been approved. Upon the developer clicking that this is ok, we overwrite the existing packaged app file, reset a few of the fields in our tables (TBD), and set the file status to PENDING so it shows up in the updated app queue.

This sounds like a nice solution so that's what I'll do for this bug unless there are objections.

Comment 3

[Wil Clouser [:clouserw]]

That sounds fine with me.  I'll tag uiwanted but I wouldn't expect feedback.

Comment 4

[Wil Clouser [:clouserw]]

untagging uiwanted.  comment 2 sounds great

Comment 5

[Andrew Williamson [:eviljeff]]

Being able to upload a new file with the same version number is fine, as long as the version hasn't been approved so users don't have it already.  I have some caveats though - 
a) however the mirroring is handled, it should more robust than how add-ons are handled right now.  Bug 794473 is an example of an all too common issue caused by the wrong copy of the file being kept around.
b) the 'version' in the database must be new one as review notes are associated with it and they can exist on non-approved versions or non-reviewed, e.g. info requests, reviewer comments.
c) the replaced version is still listed in the review history - ideally with the packaged file so we can compare to it.

Comment 6

[Andrew Williamson [:eviljeff]]

(In reply to Rob Hudson [:robhudson] from comment #0)
> For packaged apps this won't work -- a "resubmit" would require a new file
> upload. 

For packakged apps that have been rejected couldn't just show the 'upload new version' section instead of the resubmit button?

Comment 7

[Rob Hudson [:robhudson]]

(In reply to Andrew Williamson [:eviljeff] from comment #6)
> For packakged apps that have been rejected couldn't just show the 'upload
> new version' section instead of the resubmit button?

Yes. I can do that.

Comment 8

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/286d9e0

Hid the resubmit form unless it's hosted.

Comment 9

[Christopher Van Wiemeersch [:cvan]]

(In reply to Rob Hudson [:robhudson] from comment #7)
> (In reply to Andrew Williamson [:eviljeff] from comment #6)
> > For packakged apps that have been rejected couldn't just show the 'upload
> > new version' section instead of the resubmit button?
> 
> Yes. I can do that.

Did you do that?

Comment 10

[Rob Hudson [:robhudson]]

Yes I did that... it was already there.

Comment 11

[Cristian Boldan]

Verified as fixed in https://marketplace-dev.allizom.org/developers/ on FF20 (Win 7)
Attaching postfix screenshot.
Closing bug.

Comment 12

[Cristian Boldan]

Attachment: postfix packaged resubmit