788503 - Peptest should use the new mozcrash module for checking minidumps

Status: RESOLVED INCOMPLETE

(Testing Graveyard :: Peptest, defect)

Description

[Andrew Halberstadt [:ahal]]

This should be very straight forward as the method used by peptest and mozcrash is the same.

https://github.com/mozilla/mozbase/blob/master/mozcrash/mozcrash/mozcrash.py

Comment 1

[(not currently active) Ted Mielczarek]

Sample usage in runcppunittests.py:
http://mxr.mozilla.org/mozilla-central/source/testing/runcppunittests.py#47

Comment 2

[Andrew Halberstadt [:ahal]]

Removing good first bug as peptest is on hold indefinitely

Comment 3

[Andrew Halberstadt [:ahal]]

Assigning to Rajul. Rajul is a contributor interested in working on peptest throughout the summer. I think this is a good first bug to get familiar with the process of creating/submitting a patch.

Rajul: 

mozcrash is a python module that lives here: https://github.com/mozilla/mozbase/tree/master/mozcrash

Basically you just want to replace the checkForCrashes function here: https://github.com/mozilla/peptest/blob/master/peptest/runpeptests.py#L161

with mozcrash.check_for_crashes().

When you have a patch generated you can upload it to this bug as an attachment (check the "patch" checkbox when creating the attachment and flag me for a review). I'd also recommend you create a user repository on github for both mozbase and peptest. If you need help with any of this or generating a patch, please let me know.