Namely: "Part 3: checkForCrashes should return true for cases where we hit an exception during minidump stackwalk" I'd make the changes in bug 808410, except I can't really face messing about with github. Boo to non-hg.m.o projects...
Also need to port bug 789275.
Summary: mozcrash's check_for_crashes() needs the changes made in bug 808410 → mozcrash's check_for_crashes() needs the changes made in bug 808410 & bug 789275
Oh and bug 813650.
Depends on: 813650
Summary: mozcrash's check_for_crashes() needs the changes made in bug 808410 & bug 789275 → mozcrash's check_for_crashes() needs the changes made in bug 808410, bug 789275 & bug 813650
As much as I dislike git/github, we need this for bug 796914, so guess I'll have to take this.
Assignee: nobody → emorley
Status: NEW → ASSIGNED
Joel said he would take this :-)
Assignee: emorley → jmaher
the only question I have is that I replaced some calls to print, log.warn(), and log.error() with stackwalk_output.append(), then we need to output this. I chose to do it in a log.warn() call, but it could be a print, or log.error(). Thoughts?
Comment on attachment 698738 [details] [diff] [review] updated to work on all versions of python (2.0) LGTM. About the log.* vs print etc - we could just use print and then it would fix bug 819038 too. Or else log.error for the PROCESS-CRASH line and log.warn for the rest (otherwise TBPL will show the the fullstacktrace in the annotated summary) - and then we update mozlog not to prefix the output, per bug 819038 comment 1.
Attachment #698738 - Flags: review?(emorley) → review+
landed on github and version bumped to 0.3.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.