813132 - mozcrash's check_for_crashes() needs the changes made in bug 808410, bug 789275 & bug 813650

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Ed Morley [:emorley]]

Namely:
"Part 3: checkForCrashes should return true for cases where we hit an exception during minidump stackwalk"

I'd make the changes in bug 808410, except I can't really face messing about with github. Boo to non-hg.m.o projects...

Comment 1

[Ed Morley [:emorley]]

Also need to port bug 789275.

Comment 2

[Ed Morley [:emorley]]

Oh and bug 813650.

Comment 3

[Ed Morley [:emorley]]

As much as I dislike git/github, we need this for bug 796914, so guess I'll have to take this.

Comment 4

[Ed Morley [:emorley]]

Joel said he would take this :-)

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: port changes over from automationutils.py (1.0)

the only question I have is that I replaced some calls to print, log.warn(), and log.error() with stackwalk_output.append(), then we need to output this.  I chose to do it in a log.warn() call, but it could be a print, or log.error().

Thoughts?

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: updated to work on all versions of python (2.0)

Comment 7

[Ed Morley [:emorley]]

Comment on attachment 698738 [details] [diff] [review]
updated to work on all versions of python (2.0)

LGTM.

About the log.* vs print etc - we could just use print and then it would fix bug 819038 too. 

Or else log.error for the PROCESS-CRASH line and log.warn for the rest (otherwise TBPL will show the the fullstacktrace in the annotated summary) - and then we update mozlog not to prefix the output, per bug 819038 comment 1.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

landed on github and version bumped to 0.3.