mail/components/shell/DirectoryProvider.{cpp,h} should be in mail/components/build

NEW
Unassigned

Status

Thunderbird
Build Config
5 years ago
2 years ago

People

(Reporter: hiro, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patchlove])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 658699 [details] [diff] [review]
Move DirectoryProvider into mail/components/build directory

Because shell directory is built only if target platform is some platforms but DirectoryProvider is not platform specific.
Attachment #658699 - Flags: review?(mbanner)
(Reporter)

Updated

5 years ago
Blocks: 788897
No longer blocks: 78897

Updated

5 years ago
Assignee: nobody → hiikezoe
Status: NEW → ASSIGNED
Version: unspecified → Trunk
Comment on attachment 658699 [details] [diff] [review]
Move DirectoryProvider into mail/components/build directory

I don't think I'd want this in the build directory. Maybe in a dirprovider dir similar to FF, but I'd really prefer to alter the ifdefs for entering the directory (I think nsSetDefaultMail.js would be installed on all platforms as well for example).
Attachment #658699 - Flags: review?(mbanner) → review-

Comment 2

3 years ago
Jcranmer, what do you think about this?
Flags: needinfo?(Pidgeot18)
I would concur with Standard8 in the r-. Given that specifying C++ libraries has become rather trivial (FINAL_LIBRARY + SOURCES), and looking at the history of this file, it seems that this ought to be moved to mail/components. Maybe we can even fix it to use JS again instead of C++, since the issue was the xpconnect console error that I'm pretty sure we're now forcibly ignoring.
Flags: needinfo?(Pidgeot18)

Comment 4

3 years ago
So would you be able to take this bug?

Updated

2 years ago
Assignee: hiikezoe → nobody
Status: ASSIGNED → NEW
Component: General → Build Config
Whiteboard: [patchlove]
You need to log in before you can comment on or make changes to this bug.