788920 - Implement a way to force reload the social provider

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

For bug 766616, whenever there is a problem with the social provider and we present an error message, we need to be able to restart the whole social provider to recover from the error  (when the user clicks "Try Again").

(This might be related to bug 785920 but it's not quite the same thing as in that one it is the working reloading itself)

Shane suggested calling SocialProvider._terminate() and then ._activate(), and reloading the UI, which I tried but that didn't seem to work properly (but maybe I did something wrong).  I'll attach the patch

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

This is what I tried so far.  Shane or Mark, can any of you take a look at this bug?

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Mark tested this more thoroughly and said that this patch actually works! Mark, could you also test if the reset-ui notification before _activate is necessary or if it can be removed?

Comment 3

[Mark Hammond [:markh] [:mhammond]]

(In reply to :Felipe Gomes from comment #2)
> Mark, could you also test if the reset-ui notification before _activate is
> necessary or if it can be removed?

I just tested and confirmed it is necessary, as we speculated over IRC

Comment 4

[Mark Hammond [:markh] [:mhammond]]

I think this bug is out of date now - we do have a full "restart" of the provider implemented.  Felipe, does that sound correct to you?

Comment 5

[Shane Caraveo (:mixedpuppy)]

we do have reload