788924 - Device Storage - Default location for device storage on windows show use SHGetFolderPath

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Doug Turner (:dougt)]

+++ This bug was initially created as a clone of Bug #788588 +++


SHGetFolderPath has CSIDL_MYMUSIC, CSIDL_MYPICTURES, and CSIDL_MYVIDEO.  We should use that instead.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Implement "pictures", "music", and "videos" special folders

Per the source-code comment, I need Doug's permission to add dierctory location.
https://mxr.mozilla.org/mozilla-central/source/xpcom/io/nsDirectoryService.cpp?rev=3d9424eb6eb4#546
So I'll ask you for review.

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Use "picture", "music", "videos" special folders for DeviceStorage API

Comment 3

[Doug Turner (:dougt)]

thanks masatoshi!

Comment 4

[Masatoshi Kimura [:emk]]

https://tbpl.mozilla.org/?tree=Try&rev=8318c4c986df
This is a Windows-only cahge.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

(In reply to Masatoshi Kimura [:emk] from comment #4)
> https://tbpl.mozilla.org/?tree=Try&rev=8318c4c986df

Green on Try.

https://hg.mozilla.org/integration/mozilla-inbound/rev/66f34fb03d41
https://hg.mozilla.org/integration/mozilla-inbound/rev/f298ffd6a36d

Should this have tests?

Comment 6

[Doug Turner (:dougt)]

No.

Comment 7

[Doug Turner (:dougt)]

(It could, but in testing mode, we redirect all of the locations to a temporary location so that we can control what files are actually present.  It would kind of be hard to create a test for something like this, but I imagine it would end up being an existence test.  That is, "is the pictures device storage object backed back a directory when not in testing mode".  I am not sure that is very useful.).

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/66f34fb03d41
https://hg.mozilla.org/mozilla-central/rev/f298ffd6a36d

Comment 9

[Jim Mathies [:jimm]]

Just an FYI, on Win7+, the default locations for where you would save these file types are defined in Library settings. The user's default "My XYZ" folder may not be the correct location. I'm going to expose the library values in bug 837932, probably through a new set of dir svc ids.