788981 - self.port.removeListener() in a content script isn't functional

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Wladimir Palant]

It seems that self.port.removeListener() isn't working at all in content scripts, self.port.once() isn't working properly either for that reason. The bug in is this line api-utils/lib/content/content-worker.js:

        let index = listeners[name].indexOf(name);

This should search the callback, not the event type:

        let index = listeners[name].indexOf(callback);

With this change things work properly.

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: s/name/callback/

All tests seem to pass with this change applied.

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 658964 [details] [diff] [review]
s/name/callback/

Thanks for the patch :)

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/2190a6471c9b65fd5d1c2b9d71b6ec9c89d7dfe3
Bug 788981:  self.port.removeListener() in a content script isn't functional r=@ochameau

Comment 5

[Alexandre Poirot [:ochameau]]

Wes, I don't think it would justify spinning another rc, but in case we do, it would be worth shipping that into 1.10.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Alexandre Poirot (:ochameau) from comment #5)
> Wes, I don't think it would justify spinning another rc, but in case we do,
> it would be worth shipping that into 1.10.

I think Will was wanting to get some doc changes into 1.10, so if he gets those in before we need to make the final call for 1.10, I'll pull this in, too.

Comment 7

[Jeff Griffiths (:canuckistani) (:⚡︎)]

+1 for putting this in 1.10.

Comment 8

[[github robot]]

Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/5703e32f2e1b4de7fd88b34473f6d0d9c13176ca
Bug 788981:  self.port.removeListener() in a content script isn't functional r=@ochameau
(cherry picked from commit 2190a6471c9b65fd5d1c2b9d71b6ec9c89d7dfe3)

Comment 9

[imam.developers]

The fix is probably correct, but self.port.removeListener() is still not functional when a different listener is reassigned afterwards: In this case the old ("removed") listener is magically reproduced and executed.

Created new bug 844433 for this to let this here sleep. Just wanted to mention it.