Closed Bug 789003 Opened 13 years ago Closed 13 years ago

Intermittent browser_586068-cascaded_restore.js | uncaught JS exception - NS_ERROR_FAILURE: Failure at chrome://browser/content/browser.js:4567

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Platform:
x86_64
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: emorley, Assigned: ttaubert)

References

Details

(Keywords: intermittent-failure)

Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound debug test mochitest-other on 2012-09-05 19:20:23 PDT for push 35e518505ef2 slave: talos-r4-snow-047 https://tbpl.mozilla.org/php/getParsedLog.php?id=15002207&tree=Mozilla-Inbound { TEST-INFO | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-cascaded_restore.js | Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.org/#5" line: 0}] TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-cascaded_restore.js | test_restore_apptabs_ondemand: load came from selected tab WARNING: NS_ENSURE_TRUE(imageSize.width > 0 && imageSize.height > 0) failed: file ../../../layout/base/nsLayoutUtils.cpp, line 3848 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-cascaded_restore.js | an unexpected uncaught JS exception reported through window.onerror - NS_ERROR_FAILURE: Failure at chrome://browser/content/browser.js:4567 Stack trace: JS frame :: chrome://mochikit/content/tests/SimpleTest/SimpleTest.js :: simpletestOnerror :: line 980 JavaScript error: chrome://browser/content/browser.js, line 4567: NS_ERROR_FAILURE: Failure TEST-INFO | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-cascaded_restore.js | Console message: [JavaScript Error: "NS_ERROR_FAILURE: Failure" {file: "chrome://browser/content/browser.js" line: 4567}] WARNING: NS_ENSURE_TRUE(mMutable) failed: file ../../../../netwerk/base/src/nsSimpleURI.cpp, line 273 WARNING: NS_ENSURE_TRUE(mMutable) failed: file ../../../../netwerk/base/src/nsSimpleURI.cpp, line 273 ++DOMWINDOW == 34 (0x14b645890) [serial = 4161] [outer = 0x14e88d1b0] WARNING: NS_ENSURE_TRUE(mMutable) failed: file ../../../../netwerk/base/src/nsSimpleURI.cpp, line 273 WARNING: NS_ENSURE_TRUE(mMutable) failed: file ../../../../netwerk/base/src/nsSimpleURI.cpp, line 273 INFO TEST-END | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_586068-cascaded_restore.js | finished in 42115ms }
Depends on: 789102
OS: Mac OS X → All
We're up to 200 of these a week, so I pushed an ignoreAllUncaughtExceptions() in http://hg.mozilla.org/integration/mozilla-inbound/rev/c671314ef408 assuming that a hypothetical future owner of sessionstore would rather find that he owns a test with two years of added uncaught exceptions than find that he owns an [orange] bug with 20,000 comments.
Whiteboard: [orange] → [orange][leave open]
Homie don't think so.
Assignee: philringnalda → nobody
(In reply to Phil Ringnalda (:philor) from comment #318) > Homie don't think so. (m-cMerge now sets assignee; suspect a [leave assignee] might be overkill)
And thank you for the ignoreAllUncaughtExceptions() :-D
Whiteboard: [orange][leave open] → [orange] exception now ignored, see comment 317
While debugging the JS engine I noticed that in the function countTabs, located at the end of browser_586068-cascaded_restore.js, the expression « window.gBrowser.tabs[i].linkedBrowser » might not be an object which cause a Type error to be raised by « browser.__SS_restoreState » in the next if statement. I don't know if this is expected but I feel like it might be related.
I'm pretty sure this will be fixed by bug 794436. I think it's the same failure. Would anyone mind if I remove ignoreAllUncaughtExceptions() again to see if that fixed it? I'll of course re-add it if it doesn't.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
wfm :-)
Whiteboard: [orange] exception now ignored, see comment 317 → [orange]
Marking as fixed by bug 794436.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.