Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Split browser_586068-cascaded_restore.js into multiple tests

RESOLVED FIXED in Firefox 17

Status

()

Firefox
Session Restore
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Trunk
Firefox 18
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox17 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 658912 [details] [diff] [review]
patch v1

browser_586068-cascaded_restore.js is quite a big file consisting of multiple tests. We have a couple of intermittent failures with this and it would certainly help to split this into multiple test files to ease debugging a little.

This should also reduce the possibility of cascading failures because at the moment it doesn't seem like the test state is cleanly restored before moving on to the next sub-test.
Attachment #658912 - Flags: review?(felipc)
(Assignee)

Comment 1

5 years ago
There are some strange style editor crashes on try. Not sure why they should be related...

https://tbpl.mozilla.org/?tree=Try&rev=5805ebce61e4
(Assignee)

Comment 2

5 years ago
Comment on attachment 658912 [details] [diff] [review]
patch v1

Style editor crashes are fixed. Need to figure out some intermittent timeout in the new tests:

https://tbpl.mozilla.org/?tree=Try&rev=3b6ef2cf072b
Attachment #658912 - Flags: review?(felipc)
(Assignee)

Updated

5 years ago
Depends on: 794436
(Assignee)

Comment 3

5 years ago
Created attachment 664915 [details] [diff] [review]
patch v2

Ok, my patch wasn't the culprit. Will be fixed by bug 794436.
Attachment #658912 - Attachment is obsolete: true
Attachment #664915 - Flags: review?(felipc)
(Assignee)

Updated

5 years ago
Blocks: 789709
(Assignee)

Comment 4

5 years ago
Looks good on try:

https://tbpl.mozilla.org/?tree=Try&rev=fd3bc18288fc
Attachment #664915 - Flags: review?(felipc) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/f6a071d71458
Whiteboard: [fixed-in-fx-team]
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/f6a071d71458
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 18

Comment 7

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/40dd33501f4f
status-firefox17: --- → fixed
Depends on: 797263
Depends on: 802953
Blocks: 809123
You need to log in before you can comment on or make changes to this bug.