789102 - Split browser_586068-cascaded_restore.js into multiple tests

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

browser_586068-cascaded_restore.js is quite a big file consisting of multiple tests. We have a couple of intermittent failures with this and it would certainly help to split this into multiple test files to ease debugging a little.

This should also reduce the possibility of cascading failures because at the moment it doesn't seem like the test state is cleanly restored before moving on to the next sub-test.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

There are some strange style editor crashes on try. Not sure why they should be related...

https://tbpl.mozilla.org/?tree=Try&rev=5805ebce61e4

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 658912 [details] [diff] [review]
patch v1

Style editor crashes are fixed. Need to figure out some intermittent timeout in the new tests:

https://tbpl.mozilla.org/?tree=Try&rev=3b6ef2cf072b

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v2

Ok, my patch wasn't the culprit. Will be fixed by bug 794436.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Looks good on try:

https://tbpl.mozilla.org/?tree=Try&rev=fd3bc18288fc

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/f6a071d71458

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/f6a071d71458

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/40dd33501f4f