Closed
Bug 789102
Opened 12 years ago
Closed 12 years ago
Split browser_586068-cascaded_restore.js into multiple tests
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
RESOLVED
FIXED
Firefox 18
Tracking | Status | |
---|---|---|
firefox17 | --- | fixed |
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
Attachments
(1 file, 1 obsolete file)
71.08 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
browser_586068-cascaded_restore.js is quite a big file consisting of multiple tests. We have a couple of intermittent failures with this and it would certainly help to split this into multiple test files to ease debugging a little. This should also reduce the possibility of cascading failures because at the moment it doesn't seem like the test state is cleanly restored before moving on to the next sub-test.
Attachment #658912 -
Flags: review?(felipc)
Assignee | ||
Comment 1•12 years ago
|
||
There are some strange style editor crashes on try. Not sure why they should be related... https://tbpl.mozilla.org/?tree=Try&rev=5805ebce61e4
Assignee | ||
Comment 2•12 years ago
|
||
Comment on attachment 658912 [details] [diff] [review] patch v1 Style editor crashes are fixed. Need to figure out some intermittent timeout in the new tests: https://tbpl.mozilla.org/?tree=Try&rev=3b6ef2cf072b
Attachment #658912 -
Flags: review?(felipc)
Assignee | ||
Comment 3•12 years ago
|
||
Ok, my patch wasn't the culprit. Will be fixed by bug 794436.
Attachment #658912 -
Attachment is obsolete: true
Attachment #664915 -
Flags: review?(felipc)
Assignee | ||
Comment 4•12 years ago
|
||
Looks good on try: https://tbpl.mozilla.org/?tree=Try&rev=fd3bc18288fc
Updated•12 years ago
|
Attachment #664915 -
Flags: review?(felipc) → review+
Assignee | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/f6a071d71458
Whiteboard: [fixed-in-fx-team]
Assignee | ||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f6a071d71458
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 18
Comment 7•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/40dd33501f4f
status-firefox17:
--- → fixed
Blocks: 809123
You need to log in
before you can comment on or make changes to this bug.
Description
•