789085 - Main-window keyboard shortcuts don't work in Metro

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

browser/metro/browser.xul defines a number of keyboard shortcuts like Accel-T (new tab) and Accel-L (focus location bar), but these aren't working for some reason; their command handlers are never called.

Comment 1

[Matt Brubeck (:mbrubeck)]

For our cross-process key handling, we ignore key events in chrome (by disabling the keyset using "KeyFilter" in browser.js) until after the content process handles them and sends us back a Browser:KeyPress message.

We are never getting that message from content, because the "keypress" listener in Content.js is never getting called for some reason.  We need to fix this, or just remove all the cross-process key event handling code.

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: remove cross-process keyboard code

This fixes the problem, though if we might want to go multi-process in the future then it would be better to figure out why Content.js never receives "keypress" events.

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: remove cross-process keyboard code

Sorry, forgot to qrefresh.

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 658932 [details] [diff] [review]
remove cross-process keyboard code

good riddance!

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Nice to see this fixed. Why was this only happening in Metro?

Comment 6

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/projects/elm/rev/0489ded051ec

(In reply to David Bolter [:davidb] from comment #5)
> Why was this only happening in Metro?

The broken code was part of the Metro front-end code; it was never used in the desktop UI.  The code was riginally from e10s Fennec; I'm still not sure why it wasn't working correctly on Windows/Metro.  Based on past work like bug 776240 it looks like this code used to work; it's probably still a good idea to figure out when and how it regressed...

Comment 7

[Matt Brubeck (:mbrubeck)]

Pushed a followup to remove some more unused code that was spewing errors to the console trying to access the removed "Browser.keyFilter":
https://hg.mozilla.org/projects/elm/rev/6b02ff1d267d

Comment 8

[Matt Brubeck (:mbrubeck)]

Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.