Closed
Bug 789111
Opened 13 years ago
Closed 13 years ago
Ion: Inline path for LIntToString
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: evilpies, Assigned: evilpies)
Details
(Whiteboard: [js:t])
Attachments
(1 file, 1 obsolete file)
3.69 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
This can't hurt and is a small win a micro-benchmark. Also makes me wonder why we don't handle some other easy stuff in ToString.
Attachment #658922 -
Flags: review?(jdemooij)
Assignee | ||
Comment 1•13 years ago
|
||
Comment on attachment 658922 [details] [diff] [review]
v1
Actually there is some failing cross compartment check I need to look at. Sorry.
Attachment #658922 -
Flags: review?(jdemooij)
Assignee | ||
Comment 2•13 years ago
|
||
Ups, Assembler::Below inverted is not Assembler::Above.
Assignee: general → evilpies
Attachment #658922 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Updated•13 years ago
|
Whiteboard: [js:t]
Assignee | ||
Updated•13 years ago
|
Attachment #658930 -
Flags: review?(jdemooij)
What benchmark is this for?
Comment 4•13 years ago
|
||
Comment on attachment 658930 [details] [diff] [review]
v2
Review of attachment 658930 [details] [diff] [review]:
-----------------------------------------------------------------
Tom, sorry for the delay here! This looks great, r=me with the comment below addressed.
::: js/src/ion/CodeGenerator.cpp
@@ +207,5 @@
> + if (!ool)
> + return false;
> +
> + masm.cmpPtr(input, ImmWord(StaticStrings::INT_STATIC_LIMIT));
> + masm.j(Assembler::AboveOrEqual, ool->entry());
This should be (maybe wrap if it's too long):
masm.branch32(Assembler::AboveOrEqual, input, Imm32(StaticStrings::INT_STATIC_LIMIT), ool->entry());
Attachment #658930 -
Flags: review?(jdemooij) → review+
Comment 5•13 years ago
|
||
I need this for bug 794475 so I pushed this for you with nit addressed
https://hg.mozilla.org/integration/mozilla-inbound/rev/978385fba015
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Assignee | ||
Comment 7•13 years ago
|
||
Hehe nice, thank you!
You need to log in
before you can comment on or make changes to this bug.
Description
•