794475 - IonMonkey: Inline string object creation

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

Combined with bug 789111 this should win about a ms on date-format-xparb, since we can handle "new String(int32)" without a stub call.

A String object has two fixed slots for the primitive value and length so creating it is pretty straight-forward.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 664966 [details] [diff] [review]
Patch

Review of attachment 664966 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/IonBuilder.h
@@ +381,5 @@
>      InliningStatus inlineMathFunction(MMathFunction::Function function, uint32 argc,
>                                        bool constructing);
>  
>      // String natives.
> +    InliningStatus inlineString(uint32 argc, bool constructing);

nit: maybe name this inlineStringObject or something?

Comment 2

[Jan de Mooij [:jandem]]

Pushed with nit fixed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/385dbb23bb34

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/385dbb23bb34