Closed
Bug 794475
Opened 10 years ago
Closed 10 years ago
IonMonkey: Inline string object creation
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
(Whiteboard: [ion:t])
Attachments
(1 file)
21.04 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
Combined with bug 789111 this should win about a ms on date-format-xparb, since we can handle "new String(int32)" without a stub call. A String object has two fixed slots for the primitive value and length so creating it is pretty straight-forward.
Attachment #664966 -
Flags: review?(dvander)
Comment on attachment 664966 [details] [diff] [review] Patch Review of attachment 664966 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/ion/IonBuilder.h @@ +381,5 @@ > InliningStatus inlineMathFunction(MMathFunction::Function function, uint32 argc, > bool constructing); > > // String natives. > + InliningStatus inlineString(uint32 argc, bool constructing); nit: maybe name this inlineStringObject or something?
Attachment #664966 -
Flags: review?(dvander) → review+
![]() |
||
Updated•10 years ago
|
Whiteboard: [ion:t]
Assignee | ||
Comment 2•10 years ago
|
||
Pushed with nit fixed: https://hg.mozilla.org/integration/mozilla-inbound/rev/385dbb23bb34
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/385dbb23bb34
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•