789408 - Some versions don't have Crashes per ADU entries in the table, but are graphed in Crashes per 100 ADUs

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

STR:

1. Load https://crash-stats.allizom.org/daily?form_selection=by_version&p=Firefox&v[]=14.0.1&v[]=18.0a1&v[]=15.0&v[]=13.0&hang_type=any&os[]=Windows&os[]=Mac&os[]=Linux&date_range_type=report&date_start=2012-08-23&date_end=2012-09-06&submit=Generate#
2. Look at Crashes per 100 ADUs (graph) vs. Crashes per ADU (table, below)

Expected Results:

Data for 15.0, 14.0.1, and 13.0 is displayed, alongside 18.0a1

Actual Results:

Only data for 18.0a1 shows up in the Crashes per ADU table

Comment 1

[Schalk Neethling [:espressive]]

This and bug 789410 seems related to me and must be due to the key used to extract the data for the table from the object. Currently still waiting to get complete access to stage db so I can point my local environment and test against the same data.

Will however try and reproduce using data from dev.db in the mean time.

Comment 2

[Schalk Neethling [:espressive]]

[:stephend] - Sent pull request https://github.com/mozilla/socorro/pull/815 - I believe this fixes this bug as well as bug 789408

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/c66bfbb6910242a1f1b95e3dafaeb7c9ec00f726
changes based on bugs 789410 and 789408

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Still seeing this; reopening.

Comment 5

[Schalk Neethling [:espressive]]

Sent and merged: https://github.com/mozilla/socorro/pull/820

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/8c4f4c968286d6e6ed582ecdb28cc95a87cf5e32
removed if statement from view fixes bug 789408

https://github.com/mozilla/socorro/commit/52c2ccdb7a2071dbf916f61739185bf9538a89aa
Merge pull request #821 from ossreleasefeed/mobeta-fixes-to-cadu-by-version-789408

removed if statement from view fixes bug 789408

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://crash-stats.allizom.org/daily?form_selection=by_version&p=Firefox&v[]=14.0.1&v[]=18.0a1&v[]=15.0&v[]=13.0&hang_type=any&os[]=Windows&os[]=Mac&os[]=Linux&date_range_type=report&date_start=2012-08-23&date_end=2012-09-06&submit=Generate -- thanks!

Comment 8

[Matt Brandt [:mbrandt]]

Attachment: qa - verified

QA verified on stage -- the Crashes per ADU table is populated with data for 18.0a1, 15.0, 14.0.1, and 13.0.