789410 - Missing Mac data in Crashes per ADU table, but it's plotted

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

STR:

1. Load https://crash-stats.allizom.org/daily?form_selection=by_os&p=Firefox&v[]=18.0a1&hang_type=any&date_range_type=report&date_start=2012-08-23&date_end=2012-09-06&submit=Generate
2. Compare the graph (orange plot line) vs. the table, below, for Mac

Expected Results:

Mac (in orange) should have data in its Crashes per ADU table

Actual Results:

Only the graph has the Mac data

Related to bug 789408?

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of another example

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

2nd screenshot is from https://crash-stats.allizom.org/daily?form_selection=by_version&p=Thunderbird&v[]=14.0&v[]=13.0.1&v[]=10.0.6esr&v[]=18.0a1&hang_type=any&os[]=Windows&os[]=Mac&os[]=Linux&date_range_type=build&date_start=2012-08-23&date_end=2012-09-06&submit=Generate

Comment 3

[Schalk Neethling [:espressive]]

[:stephend] - Sent pull request https://github.com/mozilla/socorro/pull/815 - I believe this fixes this bug as well as bug 789408

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/c66bfbb6910242a1f1b95e3dafaeb7c9ec00f726
changes based on bugs 789410 and 789408

https://github.com/mozilla/socorro/commit/59b34f042683764704d4f282b3a39072f7297574
Merge pull request #815 from ossreleasefeed/mobeta-crashes-per-adu-771129

changes for crashes per ADU fixes bug 789410 and bug 789408

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

I can still reproduce this bug on staging (including the fix -- I double-checked), so reopening.

Comment 6

[Schalk Neethling [:espressive]]

There is a small piece of this puzzle that is missing, i.e. a piece of code not deployed to stage as the platform name for Mac should be displayed as Mac OS X on the front end and not Mac is it is currently in the screen shot and when launching the page.

As such, the key being used in the code to retrieve the information from the object is not finding a match and hence the data is not loaded. I am comparing the code in the master repo with mine at the moment and will open a pull request for whatever is missing as needed.

The above also applies to bug 789408

Comment 7

[Laura Thomson :laura]

Also note that the first screen shot shows "by os" which is known not to work - we decided to ignore this for now, since it's not used.  I can't lay hands on the bug at the moment.  Need to dig this up, but you can avoid QA on "By OS"

The second screenshot/issue is for Thunderbird, and I believe it's a lack of data issue.  Talked to Schalk and it sounds like he wants to put in better error handling for this case.

Comment 8

[Schalk Neethling [:espressive]]

Attachment: This is what I see for by OS

This is what I see for by OS locally pointed to dev.db

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://crash-stats.allizom.org/daily?form_selection=by_os&p=Firefox&v[]=18.0a1&hang_type=any&date_range_type=report&date_start=2012-08-23&date_end=2012-09-06&submit=Generate