789576 - Automatically linkify "bug XXXXXX" when present in tree status reason/motd

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Graeme McCutcheon [:graememcc]]

Per https://github.com/catlee/treestatus/pull/28/ catlee would prefer this is handled on the TBPL side rather than the TreeStatus side.

Again, I'm using the simple heuristic that a bug number followed by a </a> is already linked, and won't change it in this case.

I'm using {6,7} for the digit count: at this stage I assume any future tree closures are not going to be due to 5-digit bugs.

Comment 1

[Graeme McCutcheon [:graememcc]]

Attachment: v1

Comment 2

[Arpad Borsos [:Swatinem]]

Comment on attachment 659343 [details] [diff] [review]
v1

Review of attachment 659343 [details] [diff] [review]:
-----------------------------------------------------------------

We already have a function for that: http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/file/2d0555694735/js/UserInterface.js#l755
Use that and we are good to go :-)

Comment 3

[Graeme McCutcheon [:graememcc]]

Attachment: v2

Ah never spotted that - thanks!

Comment 4

[Arpad Borsos [:Swatinem]]

Comment on attachment 659351 [details] [diff] [review]
v2

Review of attachment 659351 [details] [diff] [review]:
-----------------------------------------------------------------

Good. Although it has no </a> handling, well then we just need to have the convention to not have linked bugs in the tree status.

Comment 5

[Graeme McCutcheon [:graememcc]]

Actually, that escapeContent() call in _linkBugs will prevent us adding other links in to the reason field - e.g. the wiki.m.o link in the current inbound message - the HTML will be rendered as plaintext.

Comment 6

[Arpad Borsos [:Swatinem]]

Hm, I missed that then. So we could add another option to prevent that.

Comment 7

[Graeme McCutcheon [:graememcc]]

Attachment: v3

Added an additional parameter to _linkBugs to signal whether to escape the string. This let me reinstate the </a> check - it was redundant when the text was escaped.

Comment 8

[Graeme McCutcheon [:graememcc]]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/fe2d7ba37836

Comment 9

[Ed Morley [:emorley]]

Thank you for this Graeme! :-)