Closed Bug 789666 Opened 12 years ago Closed 11 years ago

recommend button state needs to handle the 'unshared' state.

Categories

(Firefox Graveyard :: SocialAPI, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: markh, Unassigned)

References

Details

When a page is shared, the element "share-button-status" is updated to reflect the fact the page was shared (that element is mainly for accessibility).  However, there is no equivalent update for when the page is unshared.

The problem is that the "shared state" is only a boolean, where false means "not shared" with an implication of "never shared".  This needs to be tri-state - from a comment in updateShareState in browser-social.js:

      // XXX - this should also be capable of reflecting that the page was
      // unshared (ie, it needs to manage three-states: (1) nothing done, (2)
      // shared, (3) shared then unshared)
      // Note that we *do* have an appropriate string from the provider for
      // this (promptMessages['unsharedLabel'] but currently lack a way of
      // tracking this state)
Why? Why would someone care to differentiate "unshared" and "not ever shared"?
IMO This is less about supporting an unshared state than it is about how we want to handle share history.  In f1 we tracked what was shared, and through which provider, but storing that in bookmarks.  I still think that is a valid feature for the future.  Without locally storing that data, we cannot know the share state before sharing unless we were to leak the url to the provider, not likely something we want to do.
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #1)
> Why? Why would someone care to differentiate "unshared" and "not ever
> shared"?

From my POV, this is mainly to support accessibility.  We currently have a hidden label which gets set to "this page has been shared", purely to help users with screen-readers be confident that the share action they just took was acted on.

Assuming that requirement is valid, then we will also want the reverse - the label will need to be set when the user explicitly unshares the page, for exactly the same reasons.
I think the transition from "This page has been shared" to "This page has not been shared" is enough of a notification.

I don't think we need a "This page has been unshared" notification.
(In reply to Jared Wein [:jaws] from comment #4)
> I think the transition from "This page has been shared" to "This page has
> not been shared" is enough of a notification.
> 
> I don't think we need a "This page has been unshared" notification.

IIRC, the label in question currently defaults to blank/empty, and after a share it gets "this page has been shared".  You are suggesting that default change from empty to "This page has not been shared", right?  That sounds fine to me, although I was under the impression that the label was to attract attention so might be distracting from an accessibility POV - maybe we should ask Marco?
Depends on: 818675
Summary: share button state needs to handle the 'unshared' state. → recommend button state needs to handle the 'unshared' state.
SocialMarks is only two-state, marked or not.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.