Closed Bug 789721 Opened 8 years ago Closed 8 years ago
.moz Browser Frames Enabled before Browser Element Prompt Service initialized
No description provided.
To prevent from installing wrapped BrowserElementPromptService in application that don't use mozbrowser. Pushed to try https://tbpl.mozilla.org/?tree=Try&rev=22cd4454a899
Mark, can you verify that this fixes the problem for you? If the commit mentioned in bug 789572 is actually the problem, I'd be surprised if this fixed anything.
Comment on attachment 659516 [details] [diff] [review] Patch Please add code to ensure that we don't run _init() twice. r=me with that change, but I'd like someone to verify that this actually fixes the problem.
Comment on attachment 659546 [details] [diff] [review] Patch Maybe this is a nit, but I'd move the |this._initialized = true| line earlier in _init() because if we throw an exception in the middle of _init(), I think we should just give up, rather than try to re-initialize when the pref changes again. r+ means you don't need to re-request review on the next patch, but I would prefer to hear from mfinkle if this solves their problem before checking it in.
Attachment #659546 - Flags: review?(justin.lebar+bug) → review+
I tested the Try build and it seems to work fine. I get the prompt when trying to install a webapp and when trying to install an add-on
Attachment #659546 - Flags: feedback?(mark.finkle) → feedback+
Since it's a trivial change and we want to get it in the next nightly, I've pushed Patrick's patch with my last nit addressed: https://hg.mozilla.org/integration/mozilla-inbound/rev/f94df8af137d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.