789965 - Update zadmin's media to Django 1.4

Status: RESOLVED FIXED

(Marketplace Graveyard :: Code Quality, defect, P4)

Description

[Rob Hudson [:robhudson]]

We upgraded to Django 1.4, but the django admin media assets haven't been updated for quite some time.

It'd be slick to copy the admin's media assets to a self-contained directory that we then build with our build scripts. This will also make it easy to update them as it's a simple copy from Django's sources.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

BUMP

Comment 2

[Rob Hudson [:robhudson]]

I looked into this once and found the media in media/css/zamboni, but it wasn't clear to me how that was created or generated and feared overwriting something important. Anyone have historical knowledge of this?

Comment 3

[Wil Clouser [:clouserw]]

Davor probably knows

Comment 4

[Christopher Van Wiemeersch [:cvan]]

Images are not fixed unfortunately: http://cl.ly/image/0n1p0k1e2v29/o

I'd hate to use staticfiles: https://docs.djangoproject.com/en/1.4/ref/contrib/staticfiles/

We might just want to do something like this: https://docs.djangoproject.com/en/1.4/howto/deployment/wsgi/modwsgi/#serving-the-admin-files

Maybe one of the djangonauts can enlighten me!

Comment 5

[Davor Spasovski [:spasovski]]

We can track a better solution for this elsewhere...I am not happy with the splicing of base.css either.

https://github.com/mozilla/zamboni/commit/a9a0bd4

Comment 6

[Christopher Van Wiemeersch [:cvan]]

This does not fix the icons at all: http://cl.ly/image/283a2N35030S They're still missing

And this 100% breaks the Featured Admin tool: http://cl.ly/image/272Y14281S28

Please revert :-)

Comment 7

[Davor Spasovski [:spasovski]]

Allan can you take a look at: http://cl.ly/image/0Z3l3v1G2z0D seems the XHR is throwing a 500 and the CSS changes made should not have caused this.

Comment 8

[Davor Spasovski [:spasovski]]

Also @cvan the broken images are <img> elms. Not saying my commit didn't break that but I am not sure how.

Comment 9

[Christopher Van Wiemeersch [:cvan]]

(In reply to Davor Spasovski [:dspasovski] from comment #8)
> Also @cvan the broken images are <img> elms. Not saying my commit didn't
> break that but I am not sure how.

Yes, but that's what this bug is all about

Comment 10

[Allen Short [:ashort]]

looks like this is bug 843801

Comment 11

[Christopher Van Wiemeersch [:cvan]]

Comment 9 still applies. Lots of confusion over this bug lol.

Comment 12

[Davor Spasovski [:spasovski]]

hacked: https://github.com/mozilla/zamboni/commit/358d8f7