789977 - search by popularity old tests failing

Status: RESOLVED FIXED

(Marketplace Graveyard :: Search, defect, P5)

Description

[Davor Spasovski [:spasovski]]

These pretty much have comments in them and are currently skipped.

search/tests/test_views.py

Comment 1

[Kumar McMillan [:kumar]]

This is the spot to focus on in fixing the tests: https://github.com/mozilla/zamboni/blob/02890f933343ae8ce22d8a194cb488d1ad6b0733/mkt/webapps/tests/test_views.py#L34
I'm not sure that sorting by weekly downloads is the right way to set up a check for order of popularity.

Comment 2

[Wil Clouser [:clouserw]]

If these tests are useless, let's delete them.  The popularity  stuff is changing with bug 830902.

Comment 3

[Rob Hudson [:robhudson]]

mkt.search.tests.test_views currently shows:
34 tests, 7 failures, 0 errors, 10 skips

The 7 failures:

1. Test fails to confirm that premium app filtering for gaia/mobile doesn't turn up a premium app.
2. Test fails to confirm that packaged apps aren't returned on desktop.
3. Test fails to confirm that mobile apps show up for mobile clients.
4, 5, 6. Test fails because of an elasticsearch error (503 response code)
7. Test fails to confirm that we hide paid apps on android because no apps are returned at all where we expected a couple free apps.

The 10 skips:
1. raise SkipTest('until category filtering comes back')
2. test_free_and_premium_inapp
3. test_mobile_applied_filters (comment says tests are currently invalid)
4-10: raise SkipTest('until popularity sort is fixed, bug 785976')


The failures look like good tests assuming the behavior we expect is still true. I'm not up on what should or shouldn't be returned by searches based on device or premium type.

These are also tests that are hitting the whole view. We've started some tests that test that the correct filters are being applied and sent to elasticsearch without needing to hit elasticsearch itself, and these may be better ported to those tests.

Comment 4

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/80ce520 removes most of the old search test code. There's only 1 skipped test now. The only real code that uses old search stuff is the featured app admin.

Comment 5

[Rob Hudson [:robhudson]]

mkt.search.tests.test_views no longer exists...
https://github.com/mozilla/zamboni/commit/8411ecc786767f8c176fedecd1050889e13d937d