790206 - Install and enable Java on OSX 10.7 & 10.8 test machines

Status: RESOLVED INCOMPLETE

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Georg Fritzsche [:gfritzsche]]

Bug 705570 showed that Java is not installed on the try slaves running OS X 10.7 & 10.8. This leads to test-suites only testing the placeholder/standin plugin, not Java itself.

Java should be installed and enabled on the test machines.

Comment 1

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(We use the same shared test pool for production testing and for try testing, so I've tweaked summary to match reality.)

I've just confirmed w/kmoir - the osx10.7 and osx 10.8 test slaves do not have java installed by default. 

What specific version of Java do you want installed? Do you care where specifically they are installed? If you need access to a loaner machine to test/verify specific version of java in specific location, please let us know and we'll get you access asap.

Comment 2

[Georg Fritzsche [:gfritzsche]]

OS X >= 10.7 comes with an integrated Java installer and placeholders. Those should be covered by Apples software updates as well, so i think there is no need for specific versions or locations. 

See e.g.: http://rics.partners.org/show_article.php?id=245

Comment 3

[Hal Wine [:hwine] use NI!]

OS X upgrade from 10.7 -> 10.8 uninstalls, forcing the user to reinstall, if they ever use java. 

Further, the upgrade from 10.7 to 10.8 de-installs java (at least from browser's point of view), so 10.8 users must manually install java.

Moving to platform support.

Comment 4

[Georg Fritzsche [:gfritzsche]]

Can i provide any additional info to help move this forward?
Would be great to get complete test-coverage and lose the oranges here.

Comment 5

[Kim Moir [:kmoir] ET]

There was some discussion regarding this bug in channel, i.e. what's the policy regarding installing Java for test machines given that the default os install that the majority of users have wouldn't include Java.  John, Hal what are your thoughts?

Comment 6

[Georg Fritzsche [:gfritzsche]]

It's worth noting that we have a few Java-specific tests. A search that probably doesn't catch them all:
http://mxr.mozilla.org/mozilla-central/search?string=%3Capplet&find=test

If the test environment only provides Java on specific platforms, we
a) wouldn't cover those tests on some platforms
b) might have to look into skipping specific tests depending on platform / platform version

Comment 7

[Kim Moir [:kmoir] ET]

I'll investigate how to install Java via Puppet on the 10.7 and 10.8 test slaves.

Comment 8

[Kim Moir [:kmoir] ET]

Attachment: patch to install java on 10.8 slaves

This is dependent on the changes in bug https://bug786177.bugzilla.mozilla.org/attachment.cgi?id=663490 where pkgdmg is refactored.

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 663496 [details] [diff] [review]
patch to install java on 10.8 slaves

Looks good.  I forgot on the other bug, too -- some comments as to where outside users might find these DMGs would be great.  Can you add those for this DMG and the command line tools?

Comment 10

[Kim Moir [:kmoir] ET]

Comment on attachment 663496 [details] [diff] [review]
patch to install java on 10.8 slaves

There's a comment in the package above with it's location (line 3), and in the the xcode command tools module.  I'll go update the documentation for these two modules now :-)

Comment 11

[Dustin J. Mitchell [:dustin] (he/him)]

I'm a dummy, sorry, I should have looked harder.

Comment 12

[Kim Moir [:kmoir] ET]

Attachment: patch to install java on 10.7 slaves

The dmg is currently just in staging.  I assume /N isn't mirrored externally, so we don't have to worry about having private directories.

Comment 13

[Rail Aliiev [:rail]]

Comment on attachment 666734 [details] [diff] [review]
patch to install java on 10.7 slaves

lgtm. 

BTW, could you submit patches with more context (we usually use 8 context lines) in the future?
I have this in my ~/.hgrc:

[diff]
git = 1
showfunc = 1
nodates = 1
unified = 8

Comment 14

[Kim Moir [:kmoir] ET]

Comment on attachment 666734 [details] [diff] [review]
patch to install java on 10.7 slaves

Sure will do that next time, thanks rail

Comment 15

[Kim Moir [:kmoir] ET]

Changed deployed and verified that slaves have Java installed.

Comment 16

[Kim Moir [:kmoir] ET]

Bug 705570 seems to indicate that although Java is installed, it's not enabled properly.

Comment 17

[Georg Fritzsche [:gfritzsche]]

Did you get a chance to check into this?

Comment 18

[Kim Moir [:kmoir] ET]

no, unfortunately I've been heads down on pandas, buildduty and a beta release

Comment 19

[Ed Morley [:emorley]]

Depending on the outcome of bug 705570, we may not need this after all (and I would presume we would rather test the OS X configuration that most of our uses have; that is no Java installed, if at all possible).

Comment 20

[Kim Moir [:kmoir] ET]

Is this still needed? Or should I close it wontfix?