Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Add social.enabled and social.active to the Important Modified Preferences in about:support

RESOLVED FIXED in Firefox 17

Status

()

Product:
Firefox
Component:
SocialAPI
RESOLVED FIXED
Reported:
5 years ago
Modified:
5 years ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

Version:
Trunk
Target:
Firefox 18
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox17 fixed)

Details

(Whiteboard: [Fx17])

Attachments

(1 attachment, 2 obsolete attachments)

Patch for checkin
740 bytes, patch
jaws
: review+
Gavin
: approval-mozilla-aurora+
Details | Diff | Splinter Review
(Assignee)

Description

•
5 years ago 
Add social.enabled to the Important Modified Preferences in about:support. We need this to help troubleshoot potential issues with the Social API after it has shipped.
(Assignee)

Comment 1

•
5 years ago 
Created attachment 660259 [details] [diff] [review]
Patch
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #660259 - Flags: review?(felipc)

Comment 2

•
5 years ago 
How about also adding social.active and social.sidebar.open?
(Assignee)

Comment 3

•
5 years ago 
Created attachment 660373 [details] [diff] [review]
Patch v2

With the other two prefs. social.sidebar.open defaults to true, so this pref will only show up in about:support if the user has disabled the sidebar.
Attachment #660259 - Attachment is obsolete: true
Attachment #660259 - Flags: review?(felipc)
Attachment #660373 - Flags: review?(gavin.sharp)
Attachment #660373 - Flags: review?(gavin.sharp) → review+
 (Assignee)

Comment 4

•
5 years ago 
Created attachment 660375 [details] [diff] [review]
Patch for checkin
Attachment #660373 - Attachment is obsolete: true
Attachment #660375 - Flags: review+
Keywords: checkin-needed

Comment 5

•
5 years ago 
https://hg.mozilla.org/integration/mozilla-inbound/rev/e265b3a3e743
Flags: in-testsuite-
Keywords: checkin-needed

Comment 6

•
5 years ago 
https://hg.mozilla.org/mozilla-central/rev/e265b3a3e743
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Attachment #660375 - Flags: approval-mozilla-aurora+
Summary: Add social.enabled to the Important Modified Preferences in about:support → Add social.enabled and social.active to the Important Modified Preferences in about:support

Comment 7

•
5 years ago 
https://hg.mozilla.org/releases/mozilla-aurora/rev/5f05ed6d4b4d
status-firefox17: --- → fixed
You need to log in before you can comment on or make changes to this bug.