790488 - shareButton tests should check behaviour of multiple tabs

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: New tests

The share button tests should check a couple of multi-tab scenarios:

* With 2 tabs on the same page and the share action taken on one of the tabs, that action if reflected when switching to the other tab.

* With 1 tab opened and shared, then the tab closed and another tab to the same URL is opened, the share state is still reflected.

The following patch is only to tests as it did all work as expected :)

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 660276 [details] [diff] [review]
New tests

Review of attachment 660276 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/browser_social_shareButton.js
@@ +200,5 @@
> +  }
> +  is(shareButton.hasAttribute("shared"), false, "Share button should not have 'shared' for the initial tab");
> +  let tab1 = gBrowser.selectedTab = gBrowser.addTab(toShare);
> +  let tab1b = gBrowser.getBrowserForTab(tab1);
> +  

nit: please remove these blank spaces.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a63439012b3

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4a63439012b3

Comment 4

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e7b0279a3f5d