The default bug view has changed. See this FAQ.

shareButton tests should check behaviour of multiple tabs

RESOLVED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: markh, Assigned: markh)

Tracking

unspecified
Firefox 18
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox17 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 660276 [details] [diff] [review]
New tests

The share button tests should check a couple of multi-tab scenarios:

* With 2 tabs on the same page and the share action taken on one of the tabs, that action if reflected when switching to the other tab.

* With 1 tab opened and shared, then the tab closed and another tab to the same URL is opened, the share state is still reflected.

The following patch is only to tests as it did all work as expected :)
Attachment #660276 - Flags: review?(jaws)
Comment on attachment 660276 [details] [diff] [review]
New tests

Review of attachment 660276 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/browser_social_shareButton.js
@@ +200,5 @@
> +  }
> +  is(shareButton.hasAttribute("shared"), false, "Share button should not have 'shared' for the initial tab");
> +  let tab1 = gBrowser.selectedTab = gBrowser.addTab(toShare);
> +  let tab1b = gBrowser.getBrowserForTab(tab1);
> +  

nit: please remove these blank spaces.
Attachment #660276 - Flags: review?(jaws) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a63439012b3
Flags: in-testsuite+
OS: Windows 7 → All
Hardware: x86_64 → All
https://hg.mozilla.org/mozilla-central/rev/4a63439012b3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Attachment #660276 - Flags: approval-mozilla-aurora+
Assignee: nobody → mhammond
https://hg.mozilla.org/releases/mozilla-aurora/rev/e7b0279a3f5d
status-firefox17: --- → fixed
You need to log in before you can comment on or make changes to this bug.