790492 - Showing installation failures on Firefox OS

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[krupa raj[:krupa]]

We need a graceful way to show installation failures within the marketplace app on Firefox OS. Right now, it is a lightbox which looks janky and hard to get rid of.

Examples of installation failures:
1. App manifest is invalid
2. remote host could not be reached

Comment 1

[Wil Clouser [:clouserw]]

Is this something the marketplace does or the platform?  I assume the platform already has these built in.

Comment 2

[Wil Clouser [:clouserw]]

Pretty sure this is an FxOS bug...  Moving to entice discussion!

Comment 3

[Jason Smith [:jsmith]]

Nope, not a b2g bug. What Krupa is probably talking about here is that if I get an error callback fired during installation of a web/packaged app, then I should produce "useful" error messages based on the error codes fired back from the mozapps API. If the error codes are insufficient for your needs, then file a platform bug in Core --> DOM: Apps.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

How should this visually look?

Comment 5

[Maureen Hanratty]

Krupa or Chris--could you post a screenshot of what it looks like now or tell us how to replicate?

Comment 6

[Christopher Van Wiemeersch [:cvan]]

Desktop:
Load https://marketplace-dev.allizom.org/app/tweetdeck/
http://cl.ly/image/0G2r0E1p2I2K/o

Mobile:
Load https://marketplace-dev.allizom.org/app/tweetdeck/?gaia=true&mobile=true&tablet=false
http://cl.ly/image/2V1e2k0R2W1I/o

Comment 7

[Josh Carpenter [:jcarpenter]]

Julien, I believe we already check for these installation failures on the FFOS side, no? Specifically:

> 1. App manifest is invalid
? 2. remote host could not be reached

Comment 8

[Josh Carpenter [:jcarpenter]]

For example, bug #839491

Comment 9

[Julien Wajsberg [:julienw]]

Yep we do that already (that was Bug 816448). However the only "clear" error is displayed in logs.

Bug 837960 is about showing better errors but I doubt it will land for v1.

Comment 10

[Christopher Van Wiemeersch [:cvan]]

I propose we reuse the messages like we did in bug 840822. These are the error messages we currently have:

            case 'MKT_CANCELLED':
            case 'DENIED':
                msg = 'cancelled';
                break;
            case 'MANIFEST_URL_ERROR':
                errSummary = gettext('The manifest could not be found at the given location.');
                break;
            case 'NETWORK_ERROR':
                errSummary = gettext('App host could not be reached.');
                break;
            case 'MANIFEST_PARSE_ERROR':
                errSummary = gettext('App manifest is unparsable.');
                break;
            case 'INVALID_MANIFEST':
                errSummary = gettext('App manifest is invalid.');
                break;
            // Marketplace specific error codes.
            case 'MKT_SERVER_ERROR':
                errSummary = gettext('Internal server error.');
                break;
            case 'MKT_INSTALL_ERROR':
                errSummary = gettext('Internal server error on app installation.');
                break;
            default:
                errSummary = gettext('Install failed. Please try again later.');
                break;

Maureen, any copy changes you want to suggest?

Comment 11

[Maureen Hanratty]

Well only 'Install failed. Please try again later.' is understandable to the average consumer (I had never heard of a manifest before I started working on the Marketplace :) Could we use that for all of them?

Comment 12

[Julien Wajsberg [:julienw]]

See Bug 816448 comment 15 what we currently have in FxOS.

Comment 13

[Potch [:potch]]

https://github.com/mozilla/fireplace/commit/336ae8f