B2G STK: Update MozStkResponse

RESOLVED FIXED in mozilla18

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: allstars.chh, Unassigned)

Tracking

Trunk
mozilla18
ARM
Gonk (Firefox OS)
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [LOE: S])

Attachments

(2 attachments)

As sicking asked in Bug 744714 comment 80, the field isUCS2 seems redundant.
Now since MozStkCommand is also provided in sendStkRespose in Bug 786831,
we could remove isUCS2 and isPacked from MozStkResponse.
(Assignee)

Updated

6 years ago
Assignee: nobody → allstars.chh
Status: NEW → ASSIGNED
Whiteboard: [LOE: S]
Comment on attachment 661119 [details] [diff] [review]
Part 1: IDL

Hi, philikon
This patch just simply removed isUCS2 and isPacked from MozStkResponse.

thanks
Attachment #661119 - Flags: review?(philipp)
Comment on attachment 661120 [details] [diff] [review]
Part 2: Impl

Hi, philikon
This is revised implementation.

Thank you.
Attachment #661120 - Flags: review?(philipp)
(Assignee)

Updated

6 years ago
Blocks: 791161
Attachment #661119 - Flags: review?(philipp) → review+
Attachment #661120 - Flags: review?(philipp) → review+
Comment on attachment 661119 [details] [diff] [review]
Part 1: IDL

Hi, sicking
This patch is to address your comment in Bug 744714 comment 80,
would you review this for me ?

Thanks you.
Attachment #661119 - Flags: superreview?(jonas)
Attachment #661119 - Flags: superreview?(jonas) → superreview+
https://hg.mozilla.org/mozilla-central/rev/447a1f0979e9
https://hg.mozilla.org/mozilla-central/rev/5926706cf446
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.