Closed Bug 790550 Opened 11 years ago Closed 11 years ago

B2G STK: Update MozStkResponse

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla18

People

(Reporter: allstars.chh, Assigned: allstars.chh)

References

Details

(Whiteboard: [LOE: S])

Attachments

(2 files)

Part 1: IDL
1.02 KB, patch
philikon
: review+
sicking
: superreview+
Details | Diff | Splinter Review
Part 2: Impl
3.35 KB, patch
philikon
: review+
Details | Diff | Splinter Review 
As sicking asked in Bug 744714 comment 80, the field isUCS2 seems redundant.
Now since MozStkCommand is also provided in sendStkRespose in Bug 786831,
we could remove isUCS2 and isPacked from MozStkResponse.
Assignee: nobody → allstars.chh
Status: NEW → ASSIGNED
Whiteboard: [LOE: S]
Comment on attachment 661119 [details] [diff] [review]
Part 1: IDL

Hi, philikon
This patch just simply removed isUCS2 and isPacked from MozStkResponse.

thanks
Attachment #661119 - Flags: review?(philipp)
Comment on attachment 661120 [details] [diff] [review]
Part 2: Impl

Hi, philikon
This is revised implementation.

Thank you.
Attachment #661120 - Flags: review?(philipp)
Attachment #661119 - Flags: review?(philipp) → review+
Attachment #661120 - Flags: review?(philipp) → review+
Comment on attachment 661119 [details] [diff] [review]
Part 1: IDL

Hi, sicking
This patch is to address your comment in Bug 744714 comment 80,
would you review this for me ?

Thanks you.
Attachment #661119 - Flags: superreview?(jonas)
Attachment #661119 - Flags: superreview?(jonas) → superreview+
https://hg.mozilla.org/mozilla-central/rev/447a1f0979e9
https://hg.mozilla.org/mozilla-central/rev/5926706cf446
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.