790550 - B2G STK: Update MozStkResponse

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

As sicking asked in Bug 744714 comment 80, the field isUCS2 seems redundant.
Now since MozStkCommand is also provided in sendStkRespose in Bug 786831,
we could remove isUCS2 and isPacked from MozStkResponse.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: IDL

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: Impl

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 661119 [details] [diff] [review]
Part 1: IDL

Hi, philikon
This patch just simply removed isUCS2 and isPacked from MozStkResponse.

thanks

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 661120 [details] [diff] [review]
Part 2: Impl

Hi, philikon
This is revised implementation.

Thank you.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 661119 [details] [diff] [review]
Part 1: IDL

Hi, sicking
This patch is to address your comment in Bug 744714 comment 80,
would you review this for me ?

Thanks you.

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

try result
https://tbpl.mozilla.org/?tree=Try&rev=5478263bda9c

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/447a1f0979e9
https://hg.mozilla.org/integration/mozilla-inbound/rev/5926706cf446

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/447a1f0979e9
https://hg.mozilla.org/mozilla-central/rev/5926706cf446