790655 - l10n-check should ensure that the update.locale is correct

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[[e-mail] (:bhearsum)]

bug 790637 describes a problem where update.locale (inside of omni.ja) said en-US instead of the locale. Because of this, we had live updates on the wire that updated all localized users to en-US. As a simple guard against this in the future, the l10n-check target should verify that update.locale is correct. This target runs as part of the build, and will turn it orange if it fails.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Ensure update.locale is correct when running l10n-check

Comment 2

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a1314ef57f3d

Comment 3

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b3e66a4b7c0b

Busted on windows:
e:\builds\moz2_slave\m-in-w32\build\obj-firefox\browser\locales\Makefile:244:0$ cd ../../dist/l10n-stage && true && (cd firefox && e:/builds/moz2_slave/m-in-w32/build/obj-firefox/_virtualenv/Scripts/python.exe e:/builds/moz2_slave/m-in-w32/build/config/optimizejars.py --deoptimize e:/builds/moz2_slave/m-in-w32/build/obj-firefox/browser/locales/../../jarlog//en-US ./ ./ && true-o omni.ja && rm -f components/binary.manifest && for m in components/*.manifest; do sed -e 's/^#binary-component/binary-component/' $m > tmp.manifest && mv tmp.manifest $m; done) && (cd firefox/webapprt && e:/builds/moz2_slave/m-in-w32/build/obj-firefox/_virtualenv/Scripts/python.exe e:/builds/moz2_slave/m-in-w32/build/config/optimizejars.py --deoptimize e:/builds/moz2_slave/m-in-w32/build/obj-firefox/browser/locales/../../jarlog//en-US ./ ./ && true-o omni.ja)
e:\builds\moz2_slave\m-in-w32\build\obj-firefox\browser\locales\Makefile:244:0: command 'cd ../../dist/l10n-stage && true && (cd firefox && e:/builds/moz2_slave/m-in-w32/build/obj-firefox/_virtualenv/Scripts/python.exe e:/builds/moz2_slave/m-in-w32/build/config/optimizejars.py --deoptimize e:/builds/moz2_slave/m-in-w32/build/obj-firefox/browser/locales/../../jarlog//en-US ./ ./ && true-o omni.ja && rm -f components/binary.manifest && for m in components/*.manifest; do sed -e 's/^#binary-component/binary-component/' $m > tmp.manifest && mv tmp.manifest $m; done) && (cd firefox/webapprt && e:/builds/moz2_slave/m-in-w32/build/obj-firefox/_virtualenv/Scripts/python.exe e:/builds/moz2_slave/m-in-w32/build/config/optimizejars.py --deoptimize e:/builds/moz2_slave/m-in-w32/build/obj-firefox/browser/locales/../../jarlog//en-US ./ ./ && true-o omni.ja)' failed, return code 127
e:\builds\moz2_slave\m-in-w32\build\browser\build.mk:77:0: command 'C:/mozilla-build/buildbotve/scripts/python.exe e:/builds/moz2_slave/m-in-w32/build/build/pymake/pymake/../make.py -C browser/locales l10n-check' failed, return code 2
/usr/bin/sh: true-o: command not found

Comment 4

[Mike Hommey [:glandium]]

What I don't get is why it seems to be replacing UNZIP when doing $(subst $(INNER_UNMAKE_PACKAGE),true,$(UNMAKE_PACKAGE))

Comment 5

[Mike Hommey [:glandium]]

Attachment: Ensure update.locale is correct when running l10n-check

Testing this on try:
https://tbpl.mozilla.org/?tree=Try&rev=8753844924e9

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 662865 [details] [diff] [review]
Ensure update.locale is correct when running l10n-check

Gets another kind of failure :(

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 662865 [details] [diff] [review]
Ensure update.locale is correct when running l10n-check

This version actually works:
https://tbpl.mozilla.org/?tree=Try&rev=e67a887b86b8

Comment 8

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2fead827aff0

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2fead827aff0