Closed
Bug 790655
Opened 9 years ago
Closed 8 years ago
l10n-check should ensure that the update.locale is correct
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla18
People
(Reporter: bhearsum, Assigned: glandium)
References
Details
Attachments
(1 file, 1 obsolete file)
1.10 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
bug 790637 describes a problem where update.locale (inside of omni.ja) said en-US instead of the locale. Because of this, we had live updates on the wire that updated all localized users to en-US. As a simple guard against this in the future, the l10n-check target should verify that update.locale is correct. This target runs as part of the build, and will turn it orange if it fails.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #661770 -
Flags: review?(ted.mielczarek)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → mh+mozilla
Updated•8 years ago
|
Attachment #661770 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 2•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1314ef57f3d
Assignee | ||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3e66a4b7c0b Busted on windows: e:\builds\moz2_slave\m-in-w32\build\obj-firefox\browser\locales\Makefile:244:0$ cd ../../dist/l10n-stage && true && (cd firefox && e:/builds/moz2_slave/m-in-w32/build/obj-firefox/_virtualenv/Scripts/python.exe e:/builds/moz2_slave/m-in-w32/build/config/optimizejars.py --deoptimize e:/builds/moz2_slave/m-in-w32/build/obj-firefox/browser/locales/../../jarlog//en-US ./ ./ && true-o omni.ja && rm -f components/binary.manifest && for m in components/*.manifest; do sed -e 's/^#binary-component/binary-component/' $m > tmp.manifest && mv tmp.manifest $m; done) && (cd firefox/webapprt && e:/builds/moz2_slave/m-in-w32/build/obj-firefox/_virtualenv/Scripts/python.exe e:/builds/moz2_slave/m-in-w32/build/config/optimizejars.py --deoptimize e:/builds/moz2_slave/m-in-w32/build/obj-firefox/browser/locales/../../jarlog//en-US ./ ./ && true-o omni.ja) e:\builds\moz2_slave\m-in-w32\build\obj-firefox\browser\locales\Makefile:244:0: command 'cd ../../dist/l10n-stage && true && (cd firefox && e:/builds/moz2_slave/m-in-w32/build/obj-firefox/_virtualenv/Scripts/python.exe e:/builds/moz2_slave/m-in-w32/build/config/optimizejars.py --deoptimize e:/builds/moz2_slave/m-in-w32/build/obj-firefox/browser/locales/../../jarlog//en-US ./ ./ && true-o omni.ja && rm -f components/binary.manifest && for m in components/*.manifest; do sed -e 's/^#binary-component/binary-component/' $m > tmp.manifest && mv tmp.manifest $m; done) && (cd firefox/webapprt && e:/builds/moz2_slave/m-in-w32/build/obj-firefox/_virtualenv/Scripts/python.exe e:/builds/moz2_slave/m-in-w32/build/config/optimizejars.py --deoptimize e:/builds/moz2_slave/m-in-w32/build/obj-firefox/browser/locales/../../jarlog//en-US ./ ./ && true-o omni.ja)' failed, return code 127 e:\builds\moz2_slave\m-in-w32\build\browser\build.mk:77:0: command 'C:/mozilla-build/buildbotve/scripts/python.exe e:/builds/moz2_slave/m-in-w32/build/build/pymake/pymake/../make.py -C browser/locales l10n-check' failed, return code 2 /usr/bin/sh: true-o: command not found
Assignee | ||
Comment 4•8 years ago
|
||
What I don't get is why it seems to be replacing UNZIP when doing $(subst $(INNER_UNMAKE_PACKAGE),true,$(UNMAKE_PACKAGE))
Assignee | ||
Comment 5•8 years ago
|
||
Testing this on try: https://tbpl.mozilla.org/?tree=Try&rev=8753844924e9
Attachment #662865 -
Flags: review?(ted.mielczarek)
Assignee | ||
Updated•8 years ago
|
Attachment #661770 -
Attachment is obsolete: true
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 662865 [details] [diff] [review] Ensure update.locale is correct when running l10n-check Gets another kind of failure :(
Attachment #662865 -
Flags: review?(ted.mielczarek)
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 662865 [details] [diff] [review] Ensure update.locale is correct when running l10n-check This version actually works: https://tbpl.mozilla.org/?tree=Try&rev=e67a887b86b8
Attachment #662865 -
Flags: review?(ted.mielczarek)
Updated•8 years ago
|
Attachment #662865 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 8•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fead827aff0
Comment 9•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2fead827aff0
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Updated•3 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•