787165 - Move omnijar packaging out of installer-stage and install rules

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Move omnijar packaging out of installer-stage and install rules

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 656978 [details] [diff] [review]
Move omnijar packaging out of installer-stage and install rules

Review of attachment 656978 [details] [diff] [review]:
-----------------------------------------------------------------

This looks straightforward, but I'm still worried that it's going to break something like l10n repackaging. I guess you should just watch that after you land.

::: toolkit/mozapps/installer/packager.mk
@@ +577,5 @@
>  MOZ_SIGN_PACKAGE_CMD=$(MOZ_SIGN_CMD) $(foreach f,$(MOZ_EXTERNAL_SIGNING_FORMAT),-f $(f))
>  endif
>  
>  ifdef MOZ_SIGN_PREPARED_PACKAGE_CMD
>  ifeq (Darwin, $(OS_ARCH)) 

Can you get rid of the trailing space on this line while you're here?

Comment 3

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d2cf237d02fd

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d2cf237d02fd

Comment 5

[Mike Hommey [:glandium]]

Backed out because of l10n update bustage.
https://hg.mozilla.org/mozilla-central/rev/d260fcec71ce

Comment 6

[Axel Hecht [:Pike]]

I suspect this also caused bug 790579

Comment 7

[Mike Hommey [:glandium]]

Attachment: Move omnijar packaging out of installer-stage and install rules.

This should solve the l10n issues.

Comment 8

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/35ab0d75e5ef

Comment 9

[Mike Hommey [:glandium]]

Fixup:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7a70792a39d

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/35ab0d75e5ef
https://hg.mozilla.org/mozilla-central/rev/b7a70792a39d