Closed Bug 787165 Opened 7 years ago Closed 7 years ago

Move omnijar packaging out of installer-stage and install rules

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla18

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Comment on attachment 656978 [details] [diff] [review]
Move omnijar packaging out of installer-stage and install rules

Review of attachment 656978 [details] [diff] [review]:
-----------------------------------------------------------------

This looks straightforward, but I'm still worried that it's going to break something like l10n repackaging. I guess you should just watch that after you land.

::: toolkit/mozapps/installer/packager.mk
@@ +577,5 @@
>  MOZ_SIGN_PACKAGE_CMD=$(MOZ_SIGN_CMD) $(foreach f,$(MOZ_EXTERNAL_SIGNING_FORMAT),-f $(f))
>  endif
>  
>  ifdef MOZ_SIGN_PREPARED_PACKAGE_CMD
>  ifeq (Darwin, $(OS_ARCH)) 

Can you get rid of the trailing space on this line while you're here?
Attachment #656978 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/mozilla-central/rev/d2cf237d02fd
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Backed out because of l10n update bustage.
https://hg.mozilla.org/mozilla-central/rev/d260fcec71ce
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I suspect this also caused bug 790579
Blocks: 790579
Depends on: 791233
Blocks: 791233
No longer depends on: 791233
No longer blocks: 791233
Depends on: 790655
This should solve the l10n issues.
Attachment #661757 - Flags: review?(ted.mielczarek)
Attachment #656978 - Attachment is obsolete: true
Attachment #661757 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/mozilla-central/rev/35ab0d75e5ef
https://hg.mozilla.org/mozilla-central/rev/b7a70792a39d
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.