790697 - Broken HTML main potentially because of very long lines

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[(no longer active)]

Attachment: Screenshot

Here's the email source: https://gist.github.com/3708860

Comment 1

[:glob ✱]

Attachment: patch v1

rfc 821 states the max length of lines in email is 1000 characters, which we may exceed.

the simple fix is to always use quoted-printable encoding, which will wrap the lines.  bug 714724 has a better overall fix.

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 660732 [details] [diff] [review]
patch v1

Review of attachment 660732 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 3

[:glob ✱]

after a discussion with lpsolit on irc about this, the crux of the issue is when a bmo extension is writing the bugmail, it's stripping the line feeds.

shifting this to a bmo only fix, which i'll expand to cover the extension(s).

Comment 4

[:glob ✱]

Attachment: patch v1

this updates profanivore to only update the html body if it profanities were found, and to always use quoted-printable transfer encoding if the body was changed.

Comment 5

[David Lawrence [:dkl]]

Comment on attachment 661796 [details] [diff] [review]
patch v1

Review of attachment 661796 [details] [diff] [review]:
-----------------------------------------------------------------

Love it. r=dkl

Comment 6

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.0/
modified extensions/Profanivore/Extension.pm
Committed revision 8343.

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/Profanivore/Extension.pm
Committed revision 8365.