Closed Bug 790750 Opened 8 years ago Closed 8 years ago

OpenBSD backend for mozboot

Categories

(Firefox Build System :: General, defect)

All
OpenBSD
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla18

People

(Reporter: gps, Assigned: gaston)

Details

Attachments

(1 file, 1 obsolete file)

It would be cool if bootstrap.py worked in OpenBSD.

See bug 774109 for another example implementation.

I think :gaston "volunteered" :)
Attached patch OpenBSD backend to mozboot (obsolete) — Splinter Review
First shot.. dunno why but it doesnt want to run from my src clone :

dawn:~/src/mozilla-central/python/mozboot/ $python2.7 bin/bootstrap.py                       
Could not load the bootstrap Python environment.

This should never happen. Consider filing a bug.
Attachment #660877 - Flags: review?(gps)
Comment on attachment 660877 [details] [diff] [review]
OpenBSD backend to mozboot

Review of attachment 660877 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this!

I refactored how commands are executed in bug 790995. I'd prefer to land this using the new run_as_root() method.

::: python/mozboot/mozboot/bootstrap.py
@@ +48,5 @@
>              args['point'] = point
>  
> +        elif sys.platform.startswith('openbsd'):
> +
> +            cls = OpenBSDBootstrapper

OpenBSDBootstrapper.__init__ takes two arguments but they aren't defined here. I'm pretty sure Python will complain at run-time.

You need to set keys in 'args' equivalent to the arguments to __init__.
Attachment #660877 - Flags: review?(gps) → feedback+
second try, this time working fine locally. on top of 790995..
Attachment #660877 - Attachment is obsolete: true
Attachment #660920 - Flags: review?(gps)
Comment on attachment 660920 [details] [diff] [review]
OpenBSD backend to mozboot

Review of attachment 660920 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

I'll land this along with bug 790995 once I have r+ there.
Attachment #660920 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/34395b7b10f6
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.