790750 - OpenBSD backend for mozboot

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

It would be cool if bootstrap.py worked in OpenBSD.

See bug 774109 for another example implementation.

I think :gaston "volunteered" :)

Comment 1

[Landry Breuil (:gaston)]

Attachment: OpenBSD backend to mozboot

First shot.. dunno why but it doesnt want to run from my src clone :

dawn:~/src/mozilla-central/python/mozboot/ $python2.7 bin/bootstrap.py                       
Could not load the bootstrap Python environment.

This should never happen. Consider filing a bug.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 660877 [details] [diff] [review]
OpenBSD backend to mozboot

Review of attachment 660877 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this!

I refactored how commands are executed in bug 790995. I'd prefer to land this using the new run_as_root() method.

::: python/mozboot/mozboot/bootstrap.py
@@ +48,5 @@
>              args['point'] = point
>  
> +        elif sys.platform.startswith('openbsd'):
> +
> +            cls = OpenBSDBootstrapper

OpenBSDBootstrapper.__init__ takes two arguments but they aren't defined here. I'm pretty sure Python will complain at run-time.

You need to set keys in 'args' equivalent to the arguments to __init__.

Comment 3

[Landry Breuil (:gaston)]

Attachment: OpenBSD backend to mozboot

second try, this time working fine locally. on top of 790995..

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 660920 [details] [diff] [review]
OpenBSD backend to mozboot

Review of attachment 660920 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

I'll land this along with bug 790995 once I have r+ there.

Comment 5

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/34395b7b10f6