790811 - No context menu item to share web content

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[u279076]

With the Social API enabled, I get a "Recommend this Site" button in the awesomebar. I don't see an equivalent item in the context menu for a website though. A couple examples of where a context menu item would be useful:

 * right-click a link on a page to share
 * right-click a video to share
 * right-click a video search result to share that video
 * right-click a page to share that page
 * right-click the share button to share/unshare

Not to get too far off on a tangent but it might be useful to also have a "Recommend this Site" in the Firefox menu bar, and a keyboard shortcut to share/unshare (for a11y).

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

The keyboard shortcut to toggle share is Ctrl+Shift+L. Press it again to get the arrow panel to show up. On Windows, press tab to access the Unshare button. Hit the spacebar to Unshare.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

I forgot to add that the comment #1 shows how to do this today. a11y support for sharing/unsharing is already present in mozilla-central and mozilla-aurora.

Comment 3

[Shane Caraveo (:mixedpuppy)]

Both the mark button and share have context menus now per bug 818675 and bug 853151

Comment 4

[u279076]

Now that we have a Share button in the Social Toolbar I'm not seeing these context menus. Should a new bug be filed to support context menus or is that not in scope?

Comment 5

[Shane Caraveo (:mixedpuppy)]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #4)
> Now that we have a Share button in the Social Toolbar I'm not seeing these
> context menus. Should a new bug be filed to support context menus or is that
> not in scope?

I just tried on all three platforms and see the context menus.  You may be hitting bug 878702.

Comment 6

[u279076]

From comment 0:

These work:
> * right-click a link on a page to share
> * right-click a page to share that page

These do not work:
> * right-click a video to share
> * right-click the share button to share/unshare

Comment 7

[Shane Caraveo (:mixedpuppy)]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #6)
> From comment 0:
> 
> These work:
> > * right-click a link on a page to share
> > * right-click a page to share that page
> 
> These do not work:
> > * right-click a video to share

I see it's working on html video elements, but not on flash.

> > * right-click the share button to share/unshare

I'm not clear on what this is, but right clicking on buttons in the toolbar generally brings up the toolbar/customization context menu.  There is no unshare, though a provider could make that functionality.

Comment 8

[Shane Caraveo (:mixedpuppy)]

(In reply to Shane Caraveo (:mixedpuppy) from comment #7)
> (In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #6)


There may be some confusion here.  The original bug is about the recommend button, which is now the Social Mark button.  So are we talking about that or Share?

Comment 9

[u279076]

(In reply to Shane Caraveo (:mixedpuppy) from comment #7)
> (In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #6)
> > From comment 0:
> > 
> > These work:
> > > * right-click a link on a page to share
> > > * right-click a page to share that page
> > 
> > These do not work:
> > > * right-click a video to share
> 
> I see it's working on html video elements, but not on flash.

Hmm, HTML5 video for me does not show Share in the context menu. For example:
http://www.youtube.com/watch?v=QKwWPQ1Orzs

> > > * right-click the share button to share/unshare
> 
> I'm not clear on what this is, but right clicking on buttons in the toolbar
> generally brings up the toolbar/customization context menu.  There is no
> unshare, though a provider could make that functionality.

I think the Share/Unshare context menu was how it worked when it was a citizen of the Awesomebar. Was this descoped when it migrated to the toolbar?

> There may be some confusion here.  The original bug is about the recommend button, 
> which is now the Social Mark button.  So are we talking about that or Share?

Yeah, I'm talking about the Share button in the context of current builds. Where is the Social Mark button so I can compare the difference?

Comment 10

[Shane Caraveo (:mixedpuppy)]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #9)
> (In reply to Shane Caraveo (:mixedpuppy) from comment #7)
> > (In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #6)
> > > From comment 0:
> > > 
> > > These work:
> > > > * right-click a link on a page to share
> > > > * right-click a page to share that page
> > > 
> > > These do not work:
> > > > * right-click a video to share
> > 
> > I see it's working on html video elements, but not on flash.
> 
> Hmm, HTML5 video for me does not show Share in the context menu. For example:
> http://www.youtube.com/watch?v=QKwWPQ1Orzs

For me at least, that is a flash video.

> > > > * right-click the share button to share/unshare
> > 
> > I'm not clear on what this is, but right clicking on buttons in the toolbar
> > generally brings up the toolbar/customization context menu.  There is no
> > unshare, though a provider could make that functionality.
> 
> I think the Share/Unshare context menu was how it worked when it was a
> citizen of the Awesomebar. Was this descoped when it migrated to the toolbar?

We cant really enforce an undo.  It changed into a simple flagging/marking system allowing the provider to handle ui around what that means.  Right now, the demo provider on github shows the use.

> > There may be some confusion here.  The original bug is about the recommend button, 
> > which is now the Social Mark button.  So are we talking about that or Share?
> 
> Yeah, I'm talking about the Share button in the context of current builds.
> Where is the Social Mark button so I can compare the difference?

Ok, Share is new.