790820 - Keyboard shortcuts can kill Social API feature

Status: RESOLVED DUPLICATE of bug 792324

(Firefox Graveyard :: SocialAPI, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Weird bug, not sure what to put for the summary :)

STR:
Enable social.enabled.
Press Ctrl+Shift+L to share the page you are on.
Press Ctrl+Shift+L to see the share popup.
Press u

Expected:
Nothing, potentially unsharing, but nothing would be acceptable.

Actual:
Sidebar is gone, toolbar button is gone, menuitems are gone. No simple way to re-enable the feature.

I'm not sure what exactly is going on here but it's pretty weird. There's no errors in the Error Console and I don't remember seeing anything in my terminal output (not running a debug build ATM).

Comment 1

[u279076]

Here is my terminal output from running a debug build at the point I press 'u':

2012-09-13T16:37:04.853Z: [dssworker] bwmworker port closed - now 1 connections.
2012-09-13T16:37:04.855Z: [dssworker] bwmworker port closed - now 1 connections.
2012-09-13T16:37:04.857Z: [dssworker] removed receiver 0
2012-09-13T16:37:04.857Z: [dssworker] bwmworker port closed - now 0 connections.
2012-09-13T16:37:04.858Z: [dssworker] bwmworker port closed - now 0 connections.
2012-09-13T16:37:04.860Z: [dssworker] bwmworker port closed - now 0 connections.
2012-09-13T16:37:04.861Z: [dssworker] bwmworker port closed - now 0 connections.
2012-09-13T16:37:04.863Z: [dssworker] bwmworker port closed - now 0 connections.
2012-09-13T16:37:04.864Z: [dssworker] bwmworker port closed - now 0 connections.
2012-09-13T16:37:04.866Z: [dssworker] bwmworker port closed - now 0 connections.
2012-09-13T16:37:04.867Z: [dssworker] bwmworker port closed - now 0 connections.
2012-09-13T16:37:04.869Z: [dssworker] bwmworker port closed - now 0 connections.
2012-09-13T16:37:04.870Z: [dssworker] bwmworker port closed - now 0 connections.
2012-09-13T16:37:04.871Z: [dssworker] bwmworker port closed - now 0 connections.
2012-09-13T16:37:04.873Z: [dssworker] bwmworker port closed - now 0 connections.
2012-09-13T16:37:04.874Z: [dssworker] bwmworker port closed - now 0 connections.
2012-09-13T16:37:04.874Z: [dssworker] bwmworker port closed - now 0 connections.
2012-09-13T16:37:04.875Z: [dssworker] bwmworker port closed - now 0 connections.
2012-09-13T16:37:04.876Z: [dssworker] bwmworker port closed - now 0 connections.
--DOCSHELL 0x13caf5fe0 == 12 [id = 20]
--DOCSHELL 0x139ff5ec0 == 11 [id = 21]
++DOMWINDOW == 27 (0x11480e9a0) [serial = 67] [outer = 0x111846090]
--DOMWINDOW == 26 (0x13a6edc50) [serial = 60] [outer = 0x0] [url = http://mixedpuppy.github.com/socialapi-demo/worker.js]
--DOMWINDOW == 25 (0x139f766e0) [serial = 62] [outer = 0x0] [url = https://motown-dev.mozillalabs.com/social/worker.js]
--DOMWINDOW == 24 (0x13caa7890) [serial = 66] [outer = 0x0] [url = https://motown-dev.mozillalabs.com/social/worker.js]
--DOMWINDOW == 23 (0x13bb8be30) [serial = 65] [outer = 0x0] [url = http://mixedpuppy.github.com/socialapi-demo/sidebar.htm]
--DOMWINDOW == 22 (0x13d030a20) [serial = 64] [outer = 0x0] [url = http://mixedpuppy.github.com/socialapi-demo/worker.js]

Comment 2

[u279076]

It's just a matter of having that Recommend panel open and pressing U. Whether you get there by mouse click or keyboard shortcut does not matter.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

What is happening is that the "U" key is firing the undoActivation() element, which happens to share the same access key, even though it is in a different panel.  By hacking browser.xul, I can confirm that *all* accesskeys in buttons in *all* panels seems to be working when any panel is open - eg:

* Start a page, then click the "star" to get the "edit bookmark" dialog.  Tab to somewhere other than a text field and press "u" - you see the same thing - social is completely disabled.

Also:

* Edit browser.xul, find the button 'editBookmarkPanelRemoveButton' and edit the oncommand attribute to something like: oncommand="dump('XXXXXXXXXXX - remove button\n');StarUI.removeBookmarkButtonCommand();"

* Show our social recommend panel and press "r" - notice the dump() is shown.

I can only speculate this is happening due to all the panels being in the same popupset but haven't attempted to verify that yet.  Certainly sounds like a XUL bug to me!

Comment 4

[Mark Hammond [:markh] [:mhammond]]

fwiw, different popupset has no impact.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

No bug here beyond the issue in bug 792324, so it's a dupe!