586085 - Add localizable language names to Firefox: Hawaiian, Hiligaynon, Kashubian

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Kevin Scannell]

I've created spell checking addons for these three languages, but the languages aren't among those in toolkit/chrome/global/languageNames.properties.

As a consequence, the names do not appear correctly in the right-click context menu when attempting to spellcheck.   The reviewers at AMO won't move these out of the sandbox until this is resolved.  They suggested renaming the files to "Hawaiian.dic", etc. but I'd prefer that they be localizable like all the other languages.

ISO 639-3 codes:
haw: Hawaiian
hil: Hiligaynon
csb: Kashubian

Comment 1

[Axel Hecht [:Pike]]

http://www.sil.org/iso639-3/documentation.asp?id=haw and friends show that there's no ISO 639-1 locale code for the three, which I'd prefer. Details on the languages can be found at http://www.ethnologue.com/show_language.asp?code=haw and friends.

I recall that there was a bug about getting full coverage for iso 639-3, but I can't find it right now. I recall commenting there that I'm not in favor of forcing all locales to cover all of it, and I would have preferred to go for a solution of having the full list in content, and just an optional opportunity in locale to explicitly overload.

Comment 2

[Kevin Scannell]

There are more than 7500 languages in ISO 639-3.   Speaking as a localizer I second the sentiment that we shouldn't be required to localize all 7500!    

I'm happy as long as all languages with active localization teams or spell-checking add-ons are present in the list.   This number is unlikely to exceed 200 anytime in the next, say, 5 years.

Comment 3

[Axel Hecht [:Pike]]

Thanks to philor, I realized that we have two bcp47 bugs, and bug 356038 is actually the one that's talking about full iso 639-3 support.

Comment 4

[Robin Lionheart]

Wikipedia's article for Lojban mentions that a Firefox add-on to make Lojban popup dictionary was proposed. It might be worthwhile to add "Lojban [jbo]" to our Preferred Languages list too.

Comment 5

[Jurk]

Kashubian (csb) localization is 85% finished. I would appreacite any help of how to submit our translation (from Narro) to make it available for Firefox 4 release etc.

Comment 6

[Axel Hecht [:Pike]]

Jurk, Kashubian localizations are off topic for this bug. For taking new locales, most of our process documentation is on https://wiki.mozilla.org/L10n:Localization_Process, technical docs are on https://developer.mozilla.org/en/Create_a_new_localization. The closest bug to what you're looking for is an old attempt documented in bug 359500. But going through the process from scratch sounds like what you're looking for.

Comment 7

[Kevin Scannell]

I've gotten a ping from a friend in the Hawaiian language community on this issue.  In addition to the spell checker (which was my original motivation), they'd like to be able to add Hawaiian as an Accept-Language in the Options->Content window.  Doing so would allow google.com and other sites to default to the language.

Comment 8

[Jurk]

Kevin,

We have since created another bug (Jan 11) and are still waiting:

https://bugzilla.mozilla.org/show_bug.cgi?id=627680

If you know who can move this forward, let me know. We've been patiently waiting for:

1. The registration of the Kashubian localization 
2. Final review/approval/release of the Kashubian language version of Firefox 4.

Let me know.

Comment 9

[[e-mail]]

Aloha. I'm probably the person Kevin is referring to regarding Hawaiian. I petitioned the ISO committee for 639-1 about 10 years ago, and they refused to issue  such a code for Hawaiian, saying that a 639-3 was sufficient.

Comment 10

[Kevin Scannell]

Mahalo Keola.  Axel, is there any legwork I can do on your behalf to make this happen?  I could try to create a patch for the three languages in the bug, for example.  Or if you're serious about trying to include a broader collection of ISO 639-3 codes instead of adding them piecemeal, I can look into that too.

Comment 12

[Gordon P. Hemsley [:GPHemsley]]

Attachment: Add support for Kashubian [csb], Hawaiian [haw], and Hiligaynon [hil]

For simplicity, creating patch for these 3 locales: Kashubian [csb], Hawaiian [haw], and Hiligaynon [hil].

Comment 14

[Axel Hecht [:Pike]]

Comment on attachment 658106 [details] [diff] [review]
Add support for Kashubian [csb], Hawaiian [haw], and Hiligaynon [hil]

Review of attachment 658106 [details] [diff] [review]:
-----------------------------------------------------------------

7 million speakers, yikes. who would have thought.

TBH, I think this is also a spellchecker bug waiting to be filed, the add-on should come with a description we can use in the UI without toolkit changes.

Comment 15

[Simon Montagu :smontagu]

Comment on attachment 658106 [details] [diff] [review]
Add support for Kashubian [csb], Hawaiian [haw], and Hiligaynon [hil]

Review of attachment 658106 [details] [diff] [review]:
-----------------------------------------------------------------

You need to patch langGroups.properties as well

Comment 16

[Gordon P. Hemsley [:GPHemsley]]

Attachment: Add support for Kashubian [csb], Hawaiian [haw], and Hiligaynon [hil] (v2)

Include langGroups:

csb = x-central-euro
haw = x-unicode
hil = x-western

(Despite being Latin-based, Hawaiian has a lot of diacritics that don't appear to be in any ISO 8859 encoding.)

Comment 17

[Gordon P. Hemsley [:GPHemsley]]

See bug 716321 comment 14 for checkin information.

Comment 18

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3c34aaab407a

Comment 19

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/mozilla-central/rev/3c34aaab407a

Comment 20

[Jurk]

x-central-euro does not contain all Kashubian letters. 

Unicode should be used instead.

Comment 21

[Gordon P. Hemsley [:GPHemsley]]

(In reply to Jurk from comment #20)
> x-central-euro does not contain all Kashubian letters. 
> 
> Unicode should be used instead.

Filed bug 792575 for that.

Comment 22

[Gordon P. Hemsley [:GPHemsley]]

(In reply to Gordon P. Hemsley [:gphemsley] from comment #21)
> (In reply to Jurk from comment #20)
> > x-central-euro does not contain all Kashubian letters. 
> > 
> > Unicode should be used instead.
> 
> Filed bug 792575 for that.

That bug has changed scope, and it was determined that the x-central-euro langGroup is fine for Kashubian.

It was, however, decided that x-unicode is too extreme for Hawaiian, so bug 793249 was opened to change it to x-western.

(LangGroups are merely groups that share font formatting properties; they are not directly tied to the encodings they suggest.)