Closed
Bug 791427
Opened 12 years ago
Closed 12 years ago
Speed up SMIL reftests on Android
Categories
(Core :: SVG, defect)
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: philor, Assigned: longsonr)
References
Details
Attachments
(1 file, 2 obsolete files)
29.78 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
I split Android reftests into 4 chunks instead of 3 because reftest-3 was taking around 80 minutes and frequently timing out or just stopping in the middle of the run, characteristic of the way tegras can only concentrate for a little while before their minds wander. That only partly improved things, and reftest-4 still takes around 75 minutes, so I did what I should have done first, and looked at the slowest test that's reported at the end of the run. That'd be "Slowest test took 287222ms (http://10.250.48.213:30112/tests/layout/reftests/svg/smil/transform/translate-pattern-1.svg)" for around 6% of the total job time, and because setup time is brutal for Android tests, more like 9% of the actual test run time, out of 1939 tests run. Waiting on a try run to see whether the next slowest is another big chunk of time, but that chunk? We can't afford that.
Reporter | ||
Comment 1•12 years ago
|
||
Slowest test took 191892ms (http://10.250.48.22:30256/tests/layout/reftests/svg/smil/transform/translate-gradient-1.svg) (7% of the test run time).
Assignee | ||
Comment 2•12 years ago
|
||
Assignee | ||
Comment 3•12 years ago
|
||
Does that make it fast enough?
Assignee | ||
Comment 4•12 years ago
|
||
50 means 50 times the size of the object i.e. 5000%, so 200% should be 1/25 the memory required.
Assignee | ||
Comment 5•12 years ago
|
||
Attachment #661466 -
Attachment is obsolete: true
Attachment #661469 -
Flags: review?(philringnalda)
Reporter | ||
Comment 6•12 years ago
|
||
That certainly should help - https://tbpl.mozilla.org/?tree=Try&rev=2d93dbe1651b&noignore=1 (noignore because armv6 R4 has a single permaorange, but it should still be useful for timing info).
Assignee | ||
Comment 7•12 years ago
|
||
That didn't help much did it? Maybe these will https://tbpl.mozilla.org/?tree=Try&rev=859809900487 https://tbpl.mozilla.org/?tree=Try&rev=99cdc7d8dc10
Assignee | ||
Comment 8•12 years ago
|
||
Passed try as https://tbpl.mozilla.org/?tree=Try&rev=859809900487
Attachment #661469 -
Attachment is obsolete: true
Attachment #661469 -
Flags: review?(philringnalda)
Attachment #661481 -
Flags: review?(dholbert)
Comment 9•12 years ago
|
||
Comment on attachment 661481 [details] [diff] [review] 3rd time lucky Hmm, interesting. So this is almost an instance of bug 781362 comment 4, but without a reliance on MozReftestInvalidate (and instead just a reliance on the CPU quieting down enough that we we can fire onload, or something?) Anyway, r=me if this makes them run faster.
Attachment #661481 -
Flags: review?(dholbert) → review+
Reporter | ||
Comment 10•12 years ago
|
||
\o/
Assignee: philringnalda → longsonr
Summary: Skip translate-pattern-1.svg on Android and investigate why it takes almost 5 minutes to run → Speed up SMIL reftests on Android
Assignee | ||
Comment 11•12 years ago
|
||
Do feel free to check this in for me please.
Reporter | ||
Comment 12•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/edbfd9e7b324 Thanks!
Comment 13•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/edbfd9e7b324
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•