Closed Bug 791427 Opened 9 years ago Closed 9 years ago

Speed up SMIL reftests on Android

Categories

(Core :: SVG, defect)

ARM
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: philor, Assigned: longsonr)

References

Details

Attachments

(1 file, 2 obsolete files)

I split Android reftests into 4 chunks instead of 3 because reftest-3 was taking around 80 minutes and frequently timing out or just stopping in the middle of the run, characteristic of the way tegras can only concentrate for a little while before their minds wander.

That only partly improved things, and reftest-4 still takes around 75 minutes, so I did what I should have done first, and looked at the slowest test that's reported at the end of the run. That'd be "Slowest test took 287222ms (http://10.250.48.213:30112/tests/layout/reftests/svg/smil/transform/translate-pattern-1.svg)" for around 6% of the total job time, and because setup time is brutal for Android tests, more like 9% of the actual test run time, out of 1939 tests run. Waiting on a try run to see whether the next slowest is another big chunk of time, but that chunk? We can't afford that.
Attached patch this should help (obsolete) — Splinter Review
Does that make it fast enough?
50 means 50 times the size of the object i.e. 5000%, so 200% should be 1/25 the memory required.
Attached patch gradient test too (obsolete) — Splinter Review
Attachment #661466 - Attachment is obsolete: true
Attachment #661469 - Flags: review?(philringnalda)
That certainly should help - https://tbpl.mozilla.org/?tree=Try&rev=2d93dbe1651b&noignore=1 (noignore because armv6 R4 has a single permaorange, but it should still be useful for timing info).
Attached patch 3rd time luckySplinter Review
Passed try as https://tbpl.mozilla.org/?tree=Try&rev=859809900487
Attachment #661469 - Attachment is obsolete: true
Attachment #661469 - Flags: review?(philringnalda)
Attachment #661481 - Flags: review?(dholbert)
Comment on attachment 661481 [details] [diff] [review]
3rd time lucky

Hmm, interesting. So this is almost an instance of bug 781362 comment 4, but without a reliance on MozReftestInvalidate (and instead just a reliance on the CPU quieting down enough that we we can fire onload, or something?)

Anyway, r=me if this makes them run faster.
Attachment #661481 - Flags: review?(dholbert) → review+
\o/
Assignee: philringnalda → longsonr
Summary: Skip translate-pattern-1.svg on Android and investigate why it takes almost 5 minutes to run → Speed up SMIL reftests on Android
Do feel free to check this in for me please.
https://hg.mozilla.org/mozilla-central/rev/edbfd9e7b324
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.