791604 - social toolbar notifications: inconsistent use of menupopup and panels

Status: RESOLVED DUPLICATE of bug 935640

(Firefox Graveyard :: SocialAPI, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

In the social toolbar area, the "provider" icon uses a <menupopup> while the other "notification" icons all use a panel, which causes a few inconsistencies in the UI:

* Clicking on the provider icon causes a menu to be shown directly under the button with no "anchor" - but clicking the other icons causes an anchored panel to be shown with an "arrow" between the button and the panel.

* If the provider popup menu is open and you click on another UI element (eg, one of the notification icons), the click acts on that item (eg, the popup closes and the panel for the notification icon opens).  However, if a notification panel is open and you click on another element, the click only closes the panel - it does not act on the click target.

These are fairly minor, but recording this anyway...

FWIW, I made an attempt to have the provider icon also use a panel, but got stuck trying to put the:

              <menuitem id="social-toggle-sidebar-menuitem"
                        type="checkbox" .../>

element in the panel - I couldn't find an element I could place in the panel that looks like a checkbox menuitem.

Comment 1

[Shane Caraveo (:mixedpuppy)]

social toolbarbutton is removed in bug 935640, the new buttons only use panels.