79162 - Crash trying to download installer for daily build

Status: VERIFIED DUPLICATE of bug 79018

(Core Graveyard :: Networking: FTP, defect)

Description

[Phil Peterson]

Using 2001-05-05-20 commercial build on NT

1. Go to ftp://sweetlou/products/client/seamonkey/windows/32bit/x86
2. Click on n6setup.exe for the 5/7 build
3. Crash

I submitted two talkback incidents for this.

Comment 1

[Phil Peterson]

Looks like wallet on the top of the stack. Reassigning to morse, cc dougt

 Call Stack:     (Signature = nsWalletlibService::OnStateChange 169259a2)
     nsWalletlibService::OnStateChange
[d:\builds\seamonkey\mozilla\extensions\wallet\src\nsWalletService.cpp, line 261]
     nsDocLoaderImpl::FireOnStateChange
[d:\builds\seamonkey\mozilla\uriloader\base\nsDocLoader.cpp, line 1090]
     nsDocLoaderImpl::FireOnStateChange
[d:\builds\seamonkey\mozilla\uriloader\base\nsDocLoader.cpp, line 1098]
     nsDocLoaderImpl::doStopDocumentLoad
[d:\builds\seamonkey\mozilla\uriloader\base\nsDocLoader.cpp, line 731]
     nsDocLoaderImpl::DocLoaderIsEmpty
[d:\builds\seamonkey\mozilla\uriloader\base\nsDocLoader.cpp, line 629]
     nsDocLoaderImpl::OnStopRequest
[d:\builds\seamonkey\mozilla\uriloader\base\nsDocLoader.cpp, line 560]
     nsLoadGroup::RemoveRequest
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsLoadGroup.cpp, line 517]
     nsFTPChannel::OnStopRequest
[d:\builds\seamonkey\mozilla\netwerk\protocol\ftp\src\nsFTPChannel.cpp, line 500]
     DataRequestForwarder::OnStopRequest
[d:\builds\seamonkey\mozilla\netwerk\protocol\ftp\src\nsFtpConnectionThread.cpp,
line 192]
     nsOnStopRequestEvent::HandleEvent
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsRequestObserverProxy.cpp, line 159]
     PL_HandleEvent [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 589]
     PL_ProcessPendingEvents
[d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 522]
     _md_EventReceiverProc [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c,
line 1070

Comment 2

[Phil Peterson]

Talked to valeski about his recent change in the wallet service. He already has
a bug on this problem.


*** This bug has been marked as a duplicate of 79018 ***

Comment 3

[Doug Turner (:dougt)]

My source file is off by a few lines, but one problem is that the call to
GetDOMWindow() may return a successfully error code and a null windows.  The
code does not check for this.  A better way is to do something like:

rv = aWebProgress->GetDOMWindow(getter_AddRefs(domWin));
if (!domWin) return NS_ERROR_FAILURE;

nsCOMPtr<nsIDOMDocument> domDoc;
rv = domWin->GetDocument(getter_AddRefs(domDoc));
if (!domDoc) return NS_ERROR_FAILURE;

Comment 4

[Stephen P. Morse]

Doug, I suggested exactly the same patch in bug 79095 (2001-05-06 08:50).  But 
Jud replied saying "I'm not sure the null check is what we want.  pavlov points 
out (in 79018) that we probably shouldn't be returning null from the 
webprogresss impl"

Comment 5

[Tom Everingham]

verified dup of 79018