Closed Bug 791669 Opened 8 years ago Closed 8 years ago

[New Tab Page] don't immediately preload the new tab page on startup

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 18

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

Attachments

(1 file)

After delayed startup, we should wait for a couple of seconds (like the download manager does before resuming) until we start preloading new tab pages in the background. This feature must not interfere with startup times.
Blocks: 791670
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attached patch patch v1Splinter Review
Attachment #662564 - Flags: review?(jaws)
Comment on attachment 662564 [details] [diff] [review]
patch v1

Review of attachment 662564 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with nit addressed.

Thanks for fixing this. Hopefully this is the last remaining piece before we can enable the preload pref.

::: browser/modules/BrowserNewTabPreloader.jsm
@@ +58,5 @@
> +    }
> +  },
> +
> +  observe: function Initializer_observe(aSubject, aTopic, aData) {
> +    if (aTopic == "browser-delayed-startup-finished") {

if (aTopic == TOPIC_DELAYED_STARTUP) {
Attachment #662564 - Flags: review?(jaws) → review+
A hardcoded 5s timer is a bit gross, can we file a followup to use some better mechanism (perhaps dependent on bug 712478)?
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #3)
> A hardcoded 5s timer is a bit gross, can we file a followup to use some
> better mechanism (perhaps dependent on bug 712478)?

Yeah I didn't like that too much either but I think we don't have a real alternative at the moment. The download panel does the same with a 10s timer to resume previous downloads. I'll file a follow-up but I'm not sure if bug 712478 can help us with that. Wouldn't we need some event/notification that tells us when user is *not* doing something? Or when the browser has finished doing the important stuff after startup?
Depends on: 793115
https://hg.mozilla.org/mozilla-central/rev/9c75ed3092e8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 18
You need to log in before you can comment on or make changes to this bug.