Remove support for NSIS 2.33

RESOLVED FIXED in Firefox 16

Status

()

Firefox
Installer
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bbondy, Assigned: bbondy)

Tracking

Trunk
Firefox 18
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox15 unaffected, firefox16 fixed, firefox17 fixed, firefox18 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
All build machines should be upgraded to use NSIS 2.46 now.  This bug is to remove the NSIS 2.33 related code which we no longer need to support.
(Assignee)

Comment 1

5 years ago
Created attachment 661790 [details] [diff] [review]
Patch v1

There may be some other stuff that I don't know about. I grepped for "2.33" but from that I think this is the only thing that should be removed.
Attachment #661790 - Flags: review?(robert.bugzilla)
(Assignee)

Comment 2

5 years ago
CC'ing aki and catlee for confirmation that we don't use NSIS 2.33 at all anymore.

Comment 3

5 years ago
Afaik, the last remaining NSIS 2.33 jobs were the win32 l10n repacks, which are now using 2.46.
(Assignee)

Comment 4

5 years ago
I guess we can land (once reviewed) and see if anyone screams :)
I'm fine with that... it can always be backed out.
Blocks: 571381
Comment on attachment 661790 [details] [diff] [review]
Patch v1

The same should be true for the !ifndef CallArtificialFunction block. r=me with that... if there are more we can get them later
Attachment #661790 - Flags: review?(robert.bugzilla) → review+
(Assignee)

Comment 7

5 years ago
Created attachment 661843 [details] [diff] [review]
Patch v2

Rebased so it can land directly on m-c with no dependencies. Removed the extra block that rstrong mentioned.

Pushed to try and if that goes well I'll land on m-i.
Carrying forward r+.
Attachment #661790 - Attachment is obsolete: true
Attachment #661843 - Flags: review+
(Assignee)

Comment 8

5 years ago
http://hg.mozilla.org/mozilla-central/rev/568593839470
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
(Assignee)

Comment 9

5 years ago
Comment on attachment 661843 [details] [diff] [review]
Patch v2

[Approval Request Comment]
(snip)
Dependency of win8, please see reasoning in Bug 791019 Comment 35
Attachment #661843 - Flags: approval-mozilla-beta?
Attachment #661843 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

5 years ago
Depends on: 791019
(Assignee)

Comment 10

5 years ago
Comment on attachment 661843 [details] [diff] [review]
Patch v2

I'm going to do a rollup patch for the involved bugs for defaults handling on Windows 8 and ask for approval all at once in bug 791019.  If that lands on aurora and beta I'll update the tracking fields in this bug and post the changesets in this bug as well.
Attachment #661843 - Flags: approval-mozilla-beta?
Attachment #661843 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

5 years ago
Blocks: 793773
(Assignee)

Updated

5 years ago
Blocks: 794071
(Assignee)

Comment 11

5 years ago
http://hg.mozilla.org/releases/mozilla-beta/rev/4130a141a36b
http://hg.mozilla.org/releases/mozilla-aurora/rev/030540c0d243
status-firefox15: --- → unaffected
status-firefox16: --- → fixed
status-firefox17: --- → fixed
status-firefox18: --- → fixed

Updated

5 years ago
Blocks: 794495
You need to log in before you can comment on or make changes to this bug.