791694 - browser shell use of NS_XPCOM_CURRENT_PROCESS_DIR breaks with bug 755724

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Jim Mathies [:jimm]]

http://mxr.mozilla.org/mozilla-central/source/browser/components/shell/src/nsWindowsShellService.cpp#201

This depends on the work in bug 789461.

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1.

This is a review for m-c even know the patch will need to be rebased slightly to land on m-c. 

After review, it will land at the same time on m-c as the new dir service provider string define (soon).

Comment 2

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/projects/elm/rev/70cd88c9e803

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 665007 [details] [diff] [review]
Patch v1.

approving this simple change assuming the final string id has been solidified in another bug.

Comment 4

[Jim Mathies [:jimm]]

(In reply to Jim Mathies [:jimm] from comment #3)
> Comment on attachment 665007 [details] [diff] [review]
> Patch v1.
> 
> approving this simple change assuming the final string id has been
> solidified in another bug.

It appears I approved the wrong patch, this comment had something to do with stub installer I think. Regardless this patch looks ok.

Comment 5

[Brian R. Bondy [:bbondy]]

wrong bug?

Comment 6

[Jim Mathies [:jimm]]

(In reply to Brian R. Bondy [:bbondy] from comment #5)
> wrong bug?

Actually now that I look at it my original review comment makes sense. :) I'm trying to track of too many bugs in my head today.

Comment 7

[Mike Hommey [:glandium]]

Attachment: Use XRE_EXECUTABLE_FILE in browser shell instead of guesswork from NS_XPCOM_CURRENT_PROCESS_DIR and MOZ_APP_NAME

Comment 8

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a9f1337be665

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a9f1337be665

Comment 11

[[e-mail]]

Comment on attachment 691785 [details] [diff] [review]
Use XRE_EXECUTABLE_FILE in browser shell instead of guesswork from NS_XPCOM_CURRENT_PROCESS_DIR and MOZ_APP_NAME

>   nsCOMPtr<nsIFile> appHelper;
>-  rv = directoryService->Get(NS_XPCOM_CURRENT_PROCESS_DIR,
>+  rv = directoryService->Get(XRE_EXECUTABLE_FILE,
>                              NS_GET_IID(nsIFile),
>                              getter_AddRefs(appHelper));
>   NS_ENSURE_SUCCESS(rv, rv);
> 
>-  rv = appHelper->AppendNative(NS_LITERAL_CSTRING("uninstall"));
>+  rv = appHelper->SetNativeLeafName(NS_LITERAL_CSTRING("uninstall"));
>   NS_ENSURE_SUCCESS(rv, rv);
Not quite sure what the point of this change was, because you weren't guessing the name of the executable here?