Closed
Bug 791774
Opened 12 years ago
Closed 12 years ago
Hook DOM lists up to the new DOM bindings
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: peterv, Assigned: peterv)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
46.00 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #661857 -
Flags: review?(bzbarsky)
Comment 1•12 years ago
|
||
Comment on attachment 661857 [details] [diff] [review]
v1
Review of attachment 661857 [details] [diff] [review]:
-----------------------------------------------------------------
::: content/base/src/FragmentOrElement.cpp
@@ +395,5 @@
> + return obj;
> + }
> +
> + *triedToWrap = true;
> + return oldproxybindings::NodeList::create(cx, scope, this);
Maybe we should have a macro for this block of code...
Assignee | ||
Comment 2•12 years ago
|
||
It should all get removed next train (when they all become |return FooBinding::Wrap(cx, scope, this, triedToWrap);|), so I don't think it matters.
![]() |
||
Comment 3•12 years ago
|
||
Comment on attachment 661857 [details] [diff] [review]
v1
r=me
Attachment #661857 -
Flags: review?(bzbarsky) → review+
![]() |
||
Comment 4•12 years ago
|
||
Peter, what's blocking this from landing?
Assignee | ||
Comment 5•12 years ago
|
||
Target Milestone: --- → mozilla18
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
![]() |
||
Updated•12 years ago
|
Blocks: ParisBindings
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•