791774 - Hook DOM lists up to the new DOM bindings

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 661857 [details] [diff] [review]
v1

Review of attachment 661857 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/FragmentOrElement.cpp
@@ +395,5 @@
> +    return obj;
> +  }
> +
> +  *triedToWrap = true;
> +  return oldproxybindings::NodeList::create(cx, scope, this);

Maybe we should have a macro for this block of code...

Comment 2

[Peter Van der Beken [:peterv]]

It should all get removed next train (when they all become |return FooBinding::Wrap(cx, scope, this, triedToWrap);|), so I don't think it matters.

Comment 3

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Comment on attachment 661857 [details] [diff] [review]
v1

r=me

Comment 4

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Peter, what's blocking this from landing?

Comment 5

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/64236acfaa80

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/64236acfaa80