791910 - Wifi: Dying message managers don't get correctly unregistered

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Currently, we have code in the DOM wifi manager that is supposed to tell the parent process when it's going away. Apparently, by the time we get notified that our process is dying, we aren't able to send messages anymore. That means that the steps (with a clean config):

* start the settings app
* close the settings app
* reopen the settings app and connect to a network

doesn't show any UI when we connect to the network since we end up trying to send a notification message to a message manager that has been torn down. bug 777200 provides a mechanism for fixing this, but in the meantime, we'll have to hack around it.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: hack

I want to check this in to fix the symptom and fix the underlying problem later.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Does this actually hack around that bug?  What code will remove the mm?  Do we keep sending failed messages to it forever?

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: better hack

This removes dead managers at the same time.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 662343 [details] [diff] [review]
better hack

This patch really puts the "Java" into "JavaScript".  At least you used a closure ;).

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 662343 [details] [diff] [review]
better hack

https://hg.mozilla.org/integration/mozilla-inbound/rev/ff173f012715

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/ff173f012715