Closed Bug 791910 Opened 7 years ago Closed 7 years ago

Wifi: Dying message managers don't get correctly unregistered

Categories

(Core :: DOM: Device Interfaces, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18
blocking-basecamp +

People

(Reporter: mrbkap, Assigned: mrbkap)

References

Details

Attachments

(1 file, 1 obsolete file)

Currently, we have code in the DOM wifi manager that is supposed to tell the parent process when it's going away. Apparently, by the time we get notified that our process is dying, we aren't able to send messages anymore. That means that the steps (with a clean config):

* start the settings app
* close the settings app
* reopen the settings app and connect to a network

doesn't show any UI when we connect to the network since we end up trying to send a notification message to a message manager that has been torn down. bug 777200 provides a mechanism for fixing this, but in the meantime, we'll have to hack around it.
Attached patch hack (obsolete) — Splinter Review
I want to check this in to fix the symptom and fix the underlying problem later.
Attachment #662005 - Flags: review?(jones.chris.g)
blocking-basecamp: --- → ?
Summary: Dying message managers don't get correctly unregistered → Wifi: Dying message managers don't get correctly unregistered
No longer depends on: 777200
Does this actually hack around that bug?  What code will remove the mm?  Do we keep sending failed messages to it forever?
Attached patch better hackSplinter Review
This removes dead managers at the same time.
Attachment #662005 - Attachment is obsolete: true
Attachment #662005 - Flags: review?(jones.chris.g)
Attachment #662343 - Flags: review?(jones.chris.g)
Comment on attachment 662343 [details] [diff] [review]
better hack

This patch really puts the "Java" into "JavaScript".  At least you used a closure ;).
Attachment #662343 - Flags: review?(jones.chris.g) → review+
blocking-basecamp: ? → +
https://hg.mozilla.org/mozilla-central/rev/ff173f012715
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.