Closed Bug 791911 Opened 8 years ago Closed 7 years ago

Wifi: Dying message managers don't get correctly unregistered (real fix)

Categories

(Core :: DOM: Device Interfaces, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18
blocking-basecamp -

People

(Reporter: mrbkap, Assigned: mrbkap)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #791910 +++

This bug tracks the work needed to fix the real bug instead of wallpapering over it.
No longer depends on: 777200
We can ship with the workaround from bug 791910 so blocking-.
blocking-basecamp: ? → -
Assignee: nobody → mrbkap
Attached patch Proposed fixSplinter Review
Note the comment about the ordering of child-process-shutdown and the permissions check!
Attachment #667172 - Flags: review?(anygregor)
Comment on attachment 667172 [details] [diff] [review]
Proposed fix

>     });
>   },
> 
>@@ -2013,12 +2008,24 @@ WifiWorker.prototype = {
>   },
> 
>   receiveMessage: function MessageManager_receiveMessage(aMessage) {
>-    if (!aMessage.target.assertPermission("wifi-manage")) {
>+    let msg = aMessage.json || {};


can you do aMessage.data?

Next time more line-context please :)
Attachment #667172 - Flags: review?(anygregor) → review+
https://hg.mozilla.org/mozilla-central/rev/0d5ac783d657
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.