791911 - Wifi: Dying message managers don't get correctly unregistered (real fix)

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

+++ This bug was initially created as a clone of Bug #791910 +++

This bug tracks the work needed to fix the real bug instead of wallpapering over it.

Comment 1

[Andrew Overholt [:overholt]]

We can ship with the workaround from bug 791910 so blocking-.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Proposed fix

Note the comment about the ordering of child-process-shutdown and the permissions check!

Comment 3

[Gregor Wagner [:gwagner]]

Comment on attachment 667172 [details] [diff] [review]
Proposed fix

>     });
>   },
> 
>@@ -2013,12 +2008,24 @@ WifiWorker.prototype = {
>   },
> 
>   receiveMessage: function MessageManager_receiveMessage(aMessage) {
>-    if (!aMessage.target.assertPermission("wifi-manage")) {
>+    let msg = aMessage.json || {};


can you do aMessage.data?

Next time more line-context please :)

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 667172 [details] [diff] [review]
Proposed fix

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d5ac783d657 (with json -> data).

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0d5ac783d657