Closed Bug 791914 Opened 12 years ago Closed 11 years ago

Work - Support mouse selection in Firefox app bar

Categories

(Firefox for Metro Graveyard :: Browser, defect)

All
Windows 8.1
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jimm, Assigned: mbrubeck)

References

Details

(Whiteboard: feature=work)

Attachments

(1 file)

We currently don't have support for this in the metro nav bar. Needs to be implemented.
Depends on: 788000
Product: Firefox → Firefox for Metro
We have support for keyboard selection.  We still need touch and mouse selection.
Blocks: 747789
Summary: No selection support in nav bar → Support keyboard, mouse, and touch selection in nav bar
Keywords: feature
Whiteboard: [metro-mvp]
Keywords: feature
Priority: -- → P1
Whiteboard: [metro-mvp] → [metro-mvp][LOE:2]
Assignee: nobody → jmathies
This doesn't add full touch-friendly text selection, but it fixes handling of "click" events from mouse (or from single-tap).  Previously we were always doing a select-all on click.  With this patch, we do that only when first focusing the field.

I had to add some code to remove the mode="edit" attribute on blur, because previously we would just leave that attribute hanging around in some cases.
Attachment #703075 - Flags: review?(jmathies)
Attachment #703075 - Flags: review?(jmathies) → review+
Comment on attachment 703075 [details] [diff] [review]
fix urlbar click handling

https://hg.mozilla.org/projects/elm/rev/dfe3adc0d7f7

Leaving this bug open for the touch selection work.
I reverted part of that change because renaming _editURI broke some other callers (oops): https://hg.mozilla.org/projects/elm/rev/3bb270536840
Blocks: 831909
Blocks: 831908
Priority: P1 → --
Whiteboard: [metro-mvp][LOE:2] → [metro-mvp][LOE:2] feature=work
No longer blocks: 747789
Summary: Support keyboard, mouse, and touch selection in nav bar → Work - Support keyboard, mouse, and touch selection in nav bar
Whiteboard: [metro-mvp][LOE:2] feature=work → feature=work
Summary: Work - Support keyboard, mouse, and touch selection in nav bar → Work - Support keyboard, mouse, and touch selection in Firefox app bar
Resolving this bug; we'll use bug 788000 for the touch-specific work.
Assignee: jmathies → mbrubeck
No longer blocks: 831909
Status: NEW → RESOLVED
Closed: 11 years ago
Component: General → Browser
No longer depends on: 788000
Hardware: x86_64 → All
Resolution: --- → FIXED
Summary: Work - Support keyboard, mouse, and touch selection in Firefox app bar → Work - Support mouse selection in Firefox app bar
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: