Closed
Bug 792029
Opened 12 years ago
Closed 12 years ago
Make SpecialPowers available in crashtests
Categories
(Testing :: Reftest, defect)
Testing
Reftest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla18
People
(Reporter: bholley, Assigned: jmaher)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.11 KB,
patch
|
ted
:
review+
bholley
:
feedback+
|
Details | Diff | Splinter Review |
Joel already has patches that gets us 90% of the way there in bug 762908. As I understand it, the reason we haven't supported SpecialPowers in reftests thus far is that we feel we don't need it, and want them to be as standards-based as possible. This makes sense for reftests, but I think crashtests are a much different use case, where it's nice to be able to force GC and such. Also, |Components| is going away for content soon, so all the crashtests that access Components.interfaces won't be doing their job unless we fix them.
Assignee | ||
Comment 1•12 years ago
|
||
this is hacky, but my comment explains why. Tested on try a couple times with all green success.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #664604 -
Flags: review?(bobbyholley+bmo)
Attachment #664604 -
Flags: feedback?(ted.mielczarek)
Reporter | ||
Comment 2•12 years ago
|
||
Comment on attachment 664604 [details] [diff] [review]
turn on specialpowers for crashtests only (1.0)
I'm not a peer here, so it needs proper review from ted.
Attachment #664604 -
Flags: review?(ted.mielczarek)
Attachment #664604 -
Flags: review?(bobbyholley+bmo)
Attachment #664604 -
Flags: feedback?(ted.mielczarek)
Attachment #664604 -
Flags: feedback+
Updated•12 years ago
|
Attachment #664604 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Updated•11 years ago
|
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•