Closed Bug 792046 Opened 7 years ago Closed 7 years ago

Improve the error message when failing to connect an XMPP/IRC account because of a broken certificate

Categories

(Thunderbird :: Instant Messaging, defect)

All
Android
defect
Not set

Tracking

(thunderbird17 fixed)

RESOLVED FIXED
Thunderbird 18.0
Tracking Status
thunderbird17 --- fixed

People

(Reporter: florian, Assigned: florian)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
We have received lots of confusing support requests for IM in Tb because when we fail to connect to an XMPP or IRC server that has a broken (or self-signed, or not satisfying NSS' requirements for any reason) certificate, we currently just display a generic and not really appropriate "The server closed the connection" error message.

The attached patch replaces this error message with an error message coming from NSS (so we don't need new localizable strings! :-)) for cases of invalid certificates.

(Note: the patch removes a string from chat/locales/en-US/irc.properties that wasn't used anyway. If the patch lands on aurora, I won't include that change there.)
Attachment #662155 - Flags: review?(clokep)
Comment on attachment 662155 [details] [diff] [review]
Patch

I already gave my comments over IRC and they were fixed. :)
Attachment #662155 - Flags: review?(clokep) → review+
(Also, thanks for fixing this!)
Assignee: nobody → florian
Status: NEW → ASSIGNED
OS: Mac OS X → Android
Hardware: x86 → All
https://hg.mozilla.org/comm-central/rev/410b8317fa4e
http://hg.instantbird.org/instantbird/rev/4e7c7af0c382
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
Comment on attachment 662155 [details] [diff] [review]
Patch

[Approval Request Comment]
User impact if declined: Confusing error message when attempting to connect through XMPP or IRC to a server with an invalid (self-signed, expired, or otherwise broken) SSL certificate. This is causing lots of support requests on Thunderbird 15.
Attachment #662155 - Flags: approval-comm-aurora?
Comment on attachment 662155 [details] [diff] [review]
Patch

I'd accept a patch without the l10n change though.
Attachment #662155 - Flags: approval-comm-aurora? → approval-comm-aurora-
Comment on attachment 662155 [details] [diff] [review]
Patch

Ok, so as long as this lands without the l10n change, a=me
Attachment #662155 - Flags: approval-comm-aurora- → approval-comm-aurora+
No longer blocks: 780749
You need to log in before you can comment on or make changes to this bug.