792046 - Improve the error message when failing to connect an XMPP/IRC account because of a broken certificate

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Florian Quèze [:florian]]

Attachment: Patch

We have received lots of confusing support requests for IM in Tb because when we fail to connect to an XMPP or IRC server that has a broken (or self-signed, or not satisfying NSS' requirements for any reason) certificate, we currently just display a generic and not really appropriate "The server closed the connection" error message.

The attached patch replaces this error message with an error message coming from NSS (so we don't need new localizable strings! :-)) for cases of invalid certificates.

(Note: the patch removes a string from chat/locales/en-US/irc.properties that wasn't used anyway. If the patch lands on aurora, I won't include that change there.)

Comment 1

[Patrick Cloke [:clokep]]

Comment on attachment 662155 [details] [diff] [review]
Patch

I already gave my comments over IRC and they were fixed. :)

Comment 2

[Patrick Cloke [:clokep]]

(Also, thanks for fixing this!)

Comment 3

[Florian Quèze [:florian]]

https://hg.mozilla.org/comm-central/rev/410b8317fa4e
http://hg.instantbird.org/instantbird/rev/4e7c7af0c382

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 662155 [details] [diff] [review]
Patch

[Approval Request Comment]
User impact if declined: Confusing error message when attempting to connect through XMPP or IRC to a server with an invalid (self-signed, expired, or otherwise broken) SSL certificate. This is causing lots of support requests on Thunderbird 15.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 662155 [details] [diff] [review]
Patch

I'd accept a patch without the l10n change though.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 662155 [details] [diff] [review]
Patch

Ok, so as long as this lands without the l10n change, a=me

Comment 7

[Florian Quèze [:florian]]

https://hg.mozilla.org/releases/comm-aurora/rev/1ed0ef01d135