792112 - Migrate licenses for old, imported themes

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[Christopher Van Wiemeersch [:cvan]]

During Theme submission, you select a Creative Commons license.

https://github.com/mozilla/zamboni/blob/master/apps/constants/licenses.py and https://github.com/mozilla/zamboni/blob/master/media/js/impala/persona_creation.js#L11

These should probably live in the `licenses` table.

Comment 1

[BrianZ]

I'm not a programmer, so not familiar enough with the referenced coding to tell what it actually does, but I would suggest that you make the normal full copyright (all rights reserved) the default choice, with the option to choose a Creative Commons license if desired, and NOT the reverse.  Early on in the history of personas, it appeared that Mozilla was trying to force designers to choose CC by stating that if they chose full copyright, then they would be liable for paying hosting fees to Mozilla for the "privilege" of sharing their artwork free of charge to the benefit of Mozilla and its users!  Mighty arrogant IMO.  That was changed later, but it still bothers me to this day, because it resulted in a number of my designs being stuck with the CC label as a result, with no way to change it without having to delete them and resubmit, losing users in the process.  Can you fix this situation by providing the option for designers to edit/change the copyright designation?

Comment 2

[Wil Clouser [:clouserw]]

(In reply to BrianZ from comment #1)
> I'm not a programmer, so not familiar enough with the referenced coding to
> tell what it actually does, but I would suggest that you make the normal
> full copyright (all rights reserved) the default choice, with the option to
> choose a Creative Commons license if desired, and NOT the reverse.  Early on
> in the history of personas, it appeared that Mozilla was trying to force
> designers to choose CC by stating that if they chose full copyright, then
> they would be liable for paying hosting fees to Mozilla for the "privilege"
> of sharing their artwork free of charge to the benefit of Mozilla and its
> users!  Mighty arrogant IMO.  That was changed later, but it still bothers
> me to this day, because it resulted in a number of my designs being stuck
> with the CC label as a result, with no way to change it without having to
> delete them and resubmit, losing users in the process.  Can you fix this
> situation by providing the option for designers to edit/change the copyright
> designation?

Please file a separate bug if you'd like to suggest modifications to the site. Thanks.

Comment 3

[BrianZ]

Sorry, don't know how, and I'm not a Mozilla employee.

Comment 4

[Andy McKay]

Click "new" at the top of this page and then "addons.mozilla.org" to create a new bug for addons.

Comment 5

[BrianZ]

(In reply to Andy McKay [:andym] from comment #4)
> Click "new" at the top of this page and then "addons.mozilla.org" to create
> a new bug for addons.

Done.
https://bugzilla.mozilla.org/show_bug.cgi?id=794166

Comment 6

[Christopher Van Wiemeersch [:cvan]]

Editing an old theme generates this error for License: http://f.cl.ly/items/293o20162t2C2g160806/Screen%20Shot%202013-03-28%20at%201.01.35%20PM.png

This is because new, AMO-uploaded themes point to different License objects. 

>>> Persona.objects.values_list('license').distinct()
[(None,), (7L,), (8L,), (9L,), (11L,), (1034L,), (1035L,)]
>>> License.objects.filter(id=1034)
[<License: All Rights Reserved>]
>>> License.objects.filter(id=1035)
[<License: Creative Commons Attribution-Noncommercial-Share Alike 3.0>]

Migration should look something like:

-- Copyright
update personas set license_id = 7 where license_id = 1034;

-- Creative Commons BY-NC-SA
update personas set license_id = 8 where license_id = 1035;

As part of this bug, make sure that the correct icons are render on the detail page.

Comment 7

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/4258fdf

Part one: defaulting to copyright license now.

Comment 8

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/ab7fa29
https://github.com/mozilla/zamboni/commit/3ef9467