79241 - Trunk crash quitting the app in the cache [@ nsCacheService::ClearPendingRequests]

Status: VERIFIED FIXED

(Core :: Networking: Cache, defect)

Description

[Scott MacGregor]

Using a debug build built on 5/07/01 noon.

After reading some mail and browsing some web pages, I crashed on exit trying 
to deactivate and clear entries.

nsCacheService::ClearPendingRequests(nsCacheEntry * entry)

Looks like the argument passed in (entry) is pointing to deleted memory).

nsCacheService::ClearPendingRequests(nsCacheEntry * 0xfeeefeee) line 1067 + 3 
bytes
nsCacheService::DeactivateAndClearEntry(PLDHashTable * 0x0278ae8c, 
PLDHashEntryHdr * 0x044874c0, unsigned int 2, void * 0x00000000) line 1113
PL_DHashTableEnumerate(PLDHashTable * 0x0278ae8c, int (PLDHashTable *, 
PLDHashEntryHdr *, unsigned int, void *)* 0x02ed2018 
nsCacheService::DeactivateAndClearEntry(struct PLDHashTable *,struct 
PLDHashEntryHdr *,unsigned int,void *), void * 0x00000000) line 459 + 34 bytes
nsCacheService::ClearActiveEntries() line 1099 + 19 bytes
nsCacheService::Shutdown(nsCacheService * const 0x0278ae60) line 308
nsCacheService::Observe(nsCacheService * const 0x0278ae64, nsISupports * 
0x00398cc0, const unsigned short * 0x0012feb4, const unsigned short * 
0x00000000) line 1123
nsObserverService::Notify(nsObserverService * const 0x00c2e598, nsISupports * 
0x00398cc0, const unsigned short * 0x0012feb4, const unsigned short * 
0x00000000) line 238
NS_ShutdownXPCOM(nsIServiceManager * 0x00000000) line 449
main(int 4, char * * 0x00398850) line 1319 + 8 bytes
m

Comment 1

[gordon]

I should be checking in a fix to this later this afternoon.

Comment 2

[gordon]

My that was presumptuous of me, marking the bug fixed before I'd checked in the 
patch.  It's checked in now...

Comment 3

[Jay Patel [:jay]]

added crash, topcrash keywords and [@ nsCacheService::ClearPendingRequests] for
future reference, as this *was* a topcrasher in recent builds.

Comment 4

[benc]

VERIFIED/lxr for the .cpp file is:

1.47gordon%netscape.comMay 7 2001 Fix for bug 78479 "frequent hang on quit after
long use" and bug 79241 "Crash quiting the app in the cache". sr=darin.