Closed
Bug 792572
Opened 12 years ago
Closed 12 years ago
Several Search engines disappears after update Aurora17.0a2 2012-09-16 from 2012-09-15 / (update 16Beta4 from 16Beta3) in ja localized version
Categories
(Mozilla Localizations :: ja / Japanese, defect)
Tracking
(firefox16+ verified, firefox17+ verified)
VERIFIED
FIXED
mozilla16
People
(Reporter: alice0775, Assigned: marsf)
References
Details
(Keywords: dataloss, intl, regression)
Attachments
(1 file)
24.60 KB,
patch
|
Pike
:
review+
|
Details | Diff | Splinter Review |
Build Identifier:
http://hg.mozilla.org/releases/mozilla-aurora/rev/006174be2306
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120919042010
Several Search engines disappears after update Aurora17.0a2 2012-09-16 from 2012-09-15.
And also several Search engines disappears after update 16Beta4 from 16Beta3.
Steps to reproduce:
1. Install Aurora17.0a2 2012-09-15 ja localized version.
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2012-09-15-04-20-08-mozilla-aurora-l10n/firefox-17.0a2.ja.win32.zip
2. Start Aurora with newly created profile
3. Observe installed Search Engines from SearchBar dropdown
Google
Yahoo! JAPAN
Amazon.co.jp
楽天市場
Yahoo!オークション
教えて!goo
Twitter
Wikipedia(ja)
4. Update from About Aurora and restart
6. Observe installed Search Engines again,
You can see only two engines.
Twitter
Wikipedia(ja)
Actual results:
Several Search engines disappears.
Expected results:
Not disappear
Reporter | ||
Comment 1•12 years ago
|
||
I found a format error of *.xml in searchplugins folder.
<?xml version="1.0" encoding="UTF-8"?> is missing at top of the file.
And several error message show in Error console
時刻: 2012/09/20 6:15:32
エラー: 実体の初めに XML またはテキスト宣言がありません。
ソースファイル: moz-nullprincipal:{2ccf0aa9-0b85-4272-9448-549a0bd509a3}
行: 5, 列: 1
ソースコード:
<?xml version="1.0" encoding="UTF-8"?>
Reporter | ||
Comment 2•12 years ago
|
||
Maybe regressed by 4575dc7ad6f9 Masahiko Imanaka — upgrade license to MPL2
Reporter | ||
Comment 3•12 years ago
|
||
Reporter | ||
Updated•12 years ago
|
Severity: normal → blocker
Reporter | ||
Comment 4•12 years ago
|
||
Comment should not place before XML Declaration.
EX.searchplugins/google-jp.xml
<!-- This Source Code Form is subject to the terms of the Mozilla Public
- License, v. 2.0. If a copy of the MPL was not distributed with this
- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
<?xml version="1.0" encoding="UTF-8"?>
<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
<ShortName>Google</ShortName>
...
Comment 5•12 years ago
|
||
note, the en-US ones don't have
<?xml version="1.0" encoding="UTF-8"?>
at all.
Moving over to Japanese.
Milos, can you cross check if we have similar problems in other locales? LSV should help there, I guess.
Component: Search → ja / Japanese
Product: Firefox → Mozilla Localizations
QA Contact: bugzilla
Target Milestone: --- → mozilla16
Version: 16 Branch → unspecified
Comment 6•12 years ago
|
||
Another good reason for why we freeze l10n at beta 4 :)
Axel - can we back out the offending change today rather than waiting for further testing?
Assignee | ||
Comment 7•12 years ago
|
||
The MPL2 patch is came from Bug 782178. They have affected to following files:
/browser/searchplugins/*.xml
/mail/searchplugins/*.xml
/suite/searchplugins/*.xml
Anyway, we must recover them by removing license lines from xml files. Or, moving them under the "<?xml ... ?>" line. Which is the best way?
(removing?)
<?xml version="1.0" encoding="UTF-8"?>
(move to here?)
Assignee | ||
Comment 8•12 years ago
|
||
And, for mobile. It's critical X-(
/mobile/searchplugins/*.xml
Comment 9•12 years ago
|
||
The safest fix is to do what en-US does, which is not having the <?xml?> prefix altogether.
Assignee | ||
Comment 10•12 years ago
|
||
This will be the safest fix.
Updated•12 years ago
|
Assignee: l10n → chimantaea_mirabilis
Comment 11•12 years ago
|
||
Comment on attachment 662853 [details] [diff] [review]
remove <?xml?> line from all search plugins
Review of attachment 662853 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks, this looks good to me.
Can you land this first on central or aurora and test the depend builds that get kicked off on those branches?
Attachment #662853 -
Flags: review+
Comment 12•12 years ago
|
||
The patch in bug 782178 places the XML comment _after_ the XML prolog. The script takes great care to do this, for obvious reasons! Example quotation from the original patch:
diff --git a/ja/browser/searchplugins/amazon-jp.xml b/ja/browser/searchplugins/amazon-jp.xml
--- a/ja/browser/searchplugins/amazon-jp.xml
+++ b/ja/browser/searchplugins/amazon-jp.xml
@@ -1,9 +1,13 @@
<?xml version="1.0" encoding="UTF-8"?>
+<!-- This Source Code Form is subject to the terms of the Mozilla Public
+ - License, v. 2.0. If a copy of the MPL was not distributed with this
+ - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
+
<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
<ShortName>Amazon.co.jp</ShortName>
Did some other tool swap them round, perhaps before checkin?
Gerv
Assignee | ||
Comment 13•12 years ago
|
||
Landed on aurora (ja/ja-JP-mac):
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/1e62dae14d83
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja-JP-mac/rev/673d5ace7844
Totally, This is our mistake (affects ja locales only).
Comment 14•12 years ago
|
||
Can you test the depend builds on ftp://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-aurora-l10n/? Thanks.
Assignee | ||
Comment 15•12 years ago
|
||
I've confirmed the fix on tinderbox build.
Assignee | ||
Comment 16•12 years ago
|
||
Comment 17•12 years ago
|
||
Hi marsf, thanks for the quick fix. Make sure you sign-off on both beta and aurora, too? Thanks.
Updated•12 years ago
|
Comment 18•12 years ago
|
||
AFAICT, we're good to close this bug, too.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 19•12 years ago
|
||
Verified this issue by updating to Firefox 16 beta 5 from Fx 15b6, Fx 16b3, Fx 16b4. Custom engines are all kept through the updates. Default engines are removed (as specified in comment 0) when updating to Fx 16b4, but they are restored when updating to Fx 16b5. Everything works fine when updating directly to Fx 16b5.
Comment 20•12 years ago
|
||
09/26 Aurora
09/27 Nightly
Also verified that when updating Firefox 17.0 Aurora and Firefox 18.0 Nightly, all the search engines are preserved.
I would like to try updating Aurora from the 09/16 build to a build with the fix, but I couldn't find the 09/16 ja build anywhere on ftp.mozilla.org/pub/mozilla.org/firefox/nightly/. If anyone can point me to where I can find it, please do so here.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•