Closed Bug 792896 Opened 12 years ago Closed 12 years ago

Fixing the permission check in PermissionSettings.js

Categories

(Firefox OS Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 792604

People

(Reporter: etienne, Unassigned)

Details

Attachments

(1 file)

Attached patch Patch proposalSplinter Review
|testExactPermissionFromPrincipal| returns a nsIPermissionManager.ALLOW_ACTION (1) when we should grant the permission, not false.

So we were never granting the permission to get/set permissions.
Attachment #663062 - Flags: review?(anygregor)
Blocks: 770731
Thanks for the patch but I just pushed a fix in bug 792604!
No longer blocks: 770731
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
Cool, trying your fix right now. Thanks!
Attachment #663062 - Flags: review?(anygregor)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: