792917 - Re-review queue breaks amo-master

Status: RESOLVED FIXED

(Marketplace Graveyard :: Code Quality, defect)

Description

[Andy McKay]

Deleting an addon can AMO causes failures.

This is because Django collects all models (even uninstalled ones):

https://github.com/django/django/blob/master/django/db/models/options.py#L405

And then tries to delete the relevant tables. At some point mkt/reviewers is imported and so the revreviewqueue is registered as a table to be deleted. However the table does not exist on the test server. This causes failures like this:

https://ci.mozilla.org/job/amo-master/7376/testReport/junit/workspace.apps.addons.tests.test_models/TestAddonDelete/test_cascades/

This is a general problem with a model existing in one site (AMO) and the relevant review queue existing in another site (Marketplace).

Comment 1

[Andy McKay]

See also bug 792916.

Comment 2

[Rob Hudson [:robhudson]]

I can take this. I'll probably just move the RereviewQueue model to editor/models.py. I had to do this with the EscalationQueue already.

Comment 3

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/59688be